Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tinker] Fix tinker build for non-p2 platforms #2480

Merged
merged 1 commit into from
Jul 19, 2022
Merged

[tinker] Fix tinker build for non-p2 platforms #2480

merged 1 commit into from
Jul 19, 2022

Conversation

scott-brust
Copy link
Member

Problem

Deprecating tinker-fqc broke tinker for non p2 platforms

Solution

Only build FQC functionality for p2 platforms

Steps to Test

build tinker / run CI

Example App

tinker

References

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@scott-brust scott-brust requested a review from avtolstoy July 19, 2022 16:36
@scott-brust scott-brust merged commit c02b242 into develop Jul 19, 2022
@scott-brust scott-brust deleted the fix/fix-tinker-build branch July 19, 2022 16:59
@scott-brust scott-brust mentioned this pull request Jul 21, 2022
Merged
@technobly technobly mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avtolstoy avtolstoy avtolstoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scott-brust @avtolstoy