Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All of the
tinker-fqc
app functionality has been rolled into the basetinker
app. There is no need for the app anymore so it should be removed. It was unnecessarily inflating the size of the combined release binaries as well, since it was being built for every platform even though it was only strictly needed for P2.Another problem solved in this release is that
tinker
was no longer able to be compiled with the standaloneapplication.cpp
file.The last major change in this PR is the creation of a
third_party/coremark
module. A fork of the public coremark repo was made, then a submodule added referencing ourparticle
branch that has the modifications needed to run coremark in the P2 FQC CPU test. Functionally things are the same, but the coremark code is no longer included in the tinker app dir.Solution
user/applications/tinker-fqc/
directorymake APP=tinker
)third_party/coremark/coremark
submodule, point it to theparticle
branch with our changesSteps to Test
Compile tinker for P2
Use cloud compile with just the application.cpp file
Example App
Use
tinker
References
Coremark submodule forked from here. Based on the barebones target
Completeness