Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Change PWM pins to better match e-series pinout for E SoM X. Fix other tests #2463

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

scott-brust
Copy link
Member

@scott-brust scott-brust commented Jul 1, 2022

Problem

There are many device-os-test-runner failures for the new esomx platform. Most are pin and PWM related due to the new platform pinmap. This PR does not fix all of them (yet)

Solution

For PWM, the general solution was to make the esomx pinmap be as close to the e-series pinmap as possible. see ticket here for details.

Steps to Test

Build and Run the device-os-test-runner for esomx:

device-os-test --device-os-dir=/Users/scottbrust/develop/device-os/ --test-dir=/Users/scottbrust/develop/device-os/user/tests/integration build esomx -v   

device-os-test --device-os-dir=/Users/scottbrust/develop/device-os/ --test-dir=/Users/scottbrust/develop/device-os/user/tests/integration run esomx -v   

Example App

Use test runner / no_fixture_long_running app

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@scott-brust scott-brust requested review from avtolstoy, XuGuohui and tstellanova and removed request for avtolstoy July 1, 2022 14:59
@scott-brust scott-brust force-pushed the fix/sc-101090/fix-esomx-tests branch from 8f15860 to 427ceec Compare July 11, 2022 18:06
@scott-brust scott-brust force-pushed the fix/sc-101090/fix-esomx-tests branch from 98cda16 to 041cef2 Compare July 12, 2022 16:36
@technobly technobly added this to the 5.0.0 milestone Jul 12, 2022
@technobly technobly changed the title [esomx]Change PWM pins to better match e-series pinout. Fix other tests [tests] Change PWM pins to better match e-series pinout for E SoM X. Fix other tests Jul 12, 2022
@scott-brust scott-brust merged commit 0557d31 into develop Jul 12, 2022
@scott-brust scott-brust deleted the fix/sc-101090/fix-esomx-tests branch July 12, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants