Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

ANLZ-940 add missing parameters to s3 settings of aws_dms_endpoint #1

Merged
merged 6 commits into from
Mar 2, 2021

Conversation

denis-stafichuk-parsable
Copy link

@denis-stafichuk-parsable denis-stafichuk-parsable commented Mar 2, 2021

and make it possible to comfortably develop it locally and publish it to Terraform registry

@denis-stafichuk-parsable denis-stafichuk-parsable changed the title ANLZ-940 ANLZ-940 add missing parameters to s3 settings of aws_dms_endpoint Denis Stafichuk 20.02.2021, 11:46 ANLZ-940 add missing parameters to s3 settings of aws_dms_endpoint Mar 2, 2021
@github-actions
Copy link

github-actions bot commented Mar 2, 2021

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @denis-stafichuk-parsable 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@denis-stafichuk-parsable denis-stafichuk-parsable merged commit a391ee5 into main Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant