This repository was archived by the owner on Nov 15, 2023. It is now read-only.
grandpa: support for hard forking any pending standard changes #5306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
|
cc @svyatonik We'll need to add support for this in the light client as well as it won't be able to sync Kusama after this. |
rphmeier
approved these changes
Mar 19, 2020
|
@andresilva Thanks, I've logged this in #5309 . Finalization on light clients is broken on Kusama anyway - see #4728 |
|
@svyatonik Yeah, I forgot that we need to change light block import to require storage proofs instead for checking authorities. |
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 19, 2020
…ytech#5306) * grandpa: support for hard forking any pending standard changes * grandpa: expose authority_set_hard_forks in block import constructor * grandpa: don't break the public api
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 19, 2020
…ytech#5306) * grandpa: support for hard forking any pending standard changes * grandpa: expose authority_set_hard_forks in block import constructor * grandpa: don't break the public api
bkchr
pushed a commit
that referenced
this pull request
Mar 24, 2020
* grandpa: support for hard forking any pending standard changes * grandpa: expose authority_set_hard_forks in block import constructor * grandpa: don't break the public api
romanb
pushed a commit
to romanb/substrate
that referenced
this pull request
Apr 2, 2020
…ytech#5306) * grandpa: support for hard forking any pending standard changes * grandpa: expose authority_set_hard_forks in block import constructor * grandpa: don't break the public api
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support in GRANDPA for defining tuples
(SetId, (BlockHash, BlockNumber), AuthorityList)which will be replace any existing pending authority set changes and additionally will also replace the signalled authority set change when importing a hard fork block (e.g. when syncing the chain after the fact).