This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make the behaviour in libp2p generic #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A8-looksgood
and removed
A0-please_review
arkpar
approved these changes
May 12, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Jul 10, 2019
* Make the behaviour in libp2p generic * Fix indentation * Fix bad merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly changes the hierarchy of the structs in network-libp2p.
Instead of
Service <-> Behaviour <-> CustomProto, we now haveService <-> Behaviour<CustomProto>.The
Servicebuilds theCustomProtoand passes it toBehaviour, instead of havingBehaviourbuild theCustomProtoitself.There's not fundamental reason for this change alone. I started working on a much bigger change to make network-libp2p entirely generic over the protocol (which is necessary for example for Ethereum 2.0 support), but then realized I was blocked. Since I have already done this part, I might as well submit it as PR. I will do the bigger change in the future.