Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

IntegrityTest implementation should be feature gated #13094

Merged
merged 3 commits into from
Jan 11, 2023
Merged

IntegrityTest implementation should be feature gated #13094

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e45a96a
`IntegrityTest` implementation should be feature gated
bkchr Jan 7, 2023
0a7ce02
Merge remote-tracking branch 'origin/master' into bkchr-integrity-tes…
bkchr Jan 11, 2023
fb6313d
Don't assume that all "consumers" have a `std` feature
bkchr Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frame/support/procedural/src/pallet/expand/hooks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ pub fn expand_hooks(def: &mut Def) -> proc_macro2::TokenStream {
}
}

#[cfg(feature = "std")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Polkadot comp CI fails.
Looks like mock_msg_pallet does not have an std feature and therefore tries to compile the integrity tests without it.
In these cases we cannot run the integrity test, so the __construct_runtime_integrity_test should probably also be std-gated.
Or we fix the mock_msg_queue to have a std feature 🤷‍♂️

impl<#type_impl_gen>
#frame_support::traits::IntegrityTest
for #pallet_ident<#type_use_gen> #where_clause
Expand Down