Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

node should print warning if it's a validator but doesn't have secret to any of the chains validators keys #533

Closed
snd opened this issue Aug 9, 2018 · 5 comments
Closed

node should print warning if it's a validator but doesn't have secret to any of the chains validators keys #533

snd opened this issue Aug 9, 2018 · 5 comments
Labels
J0-enhancement An additional feature request.
Milestone
1.0 beta

Comments

@snd
Copy link
Contributor

snd commented Aug 9, 2018

currently it just seems to silently not validate blocks. a helpful warning log message would help with troubleshooting
@snd snd added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Aug 9, 2018
@snd snd changed the title node should print warning if it's a validator but doesn't have any of the chains validators keys node should print warning if it's a validator but doesn't have secret to any of the chains validators keys Aug 9, 2018
@snd snd added the M4-core label Aug 9, 2018
@gavofyork
Copy link
Member

it already does this:

2018-08-10 15:04:33 BFT agreement error: Message sender 7a1a7881f04bf11369648e90949b053566a71fe0a932a86f880c66c06babd5ab is not a valid authority.

@gavofyork
Copy link
Member

(though the wording could be improved)

@snd
Copy link
Contributor Author

snd commented Aug 14, 2018

i see. in my tests it didn't print it. though i'm using polkadot::service directly and not spawning a node. will try to figure out why. might just be log settings

@gavofyork gavofyork added this to the PoC-3 (GRANDPA) milestone Sep 5, 2018
@gavofyork
Copy link
Member

would be good to have --validator on-by-default and have extra logging (perhaps part of the informant) when taking part in consensus.

@gavofyork gavofyork added J0-enhancement An additional feature request. and removed I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. labels Sep 11, 2018
@gavofyork
Copy link
Member

Will close in favour of doing #543 properly.

lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
@xlc @gavofyork
add comments for WonRenewal event (paritytech#533)
403f530 
* add comments for WonRenewal event

* make event argument order consistent
liuchengxu pushed a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
@gguoss
Follow substrate executive (paritytech#533)
79503a1
liuchengxu pushed a commit to autonomys/substrate that referenced this issue Jun 3, 2022
@nazar-pc
Merge pull request paritytech#533 from subspace/subspace-substrate-fork
40e0090 
Switch to Subspace's Substrate fork
helin6 pushed a commit to boolnetwork/substrate that referenced this issue Jul 25, 2023
@lexnv
Update artifacts and polkadot.rs and change CLI to default bytes (par…
1658e8d 
…itytech#533)

* Update polkadot.rs

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Update artifacts

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Change CLI default to bytes

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J0-enhancement An additional feature request.
Projects
None yet
Milestone
1.0 beta
Development

No branches or pull requests
2 participants
@snd @gavofyork