Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Heap size should be an on-chain parameter #312

Closed
gavofyork opened this issue Jul 14, 2018 · 9 comments · Fixed by #639
Closed

Heap size should be an on-chain parameter #312

gavofyork opened this issue Jul 14, 2018 · 9 comments · Fixed by #639
Labels
Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Milestone

Comments

@gavofyork
Copy link
Member

gavofyork commented Jul 14, 2018

At present the heap size is hard-coded to 128x 64KB pages (8MB); it should instead be specified as an on-chain similar to :code. The key could be :heapsize.

@gavofyork gavofyork added F5-task Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels Jul 14, 2018
@gavofyork gavofyork added this to the PoC-3 (AFG) milestone Jul 14, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 225.0 DAI (225.0 USD @ $1.0/DAI) attached to it.

@dapperAuteur
Copy link

Hey @gavofyork , I'd like to work with you on this bounty. I'd like to use it as an opportunity to learn more about the product.

@dapperAuteur
Copy link

@gavofyork do you have time this week or next week to talk about this issue?

@gitcoinbot
Copy link

@dapperAuteur Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@dapperAuteur
Copy link

dapperAuteur commented Aug 14, 2018

I'm going to stop work. I added myself to this issue with the hopes of helping and learning. I wasn't able to open up communication with the bounty funder to learn anything about it. I may not have made my intentions clear when I started work on this bounty. I'm going to stop work now. I'll continue to learn about Rust and hopefully I'll be better equiped to help on future issues.

@gavofyork
Copy link
Member Author

Hey - sorry for not replying - Github quoting in not an effective means to get my attention. If you do start work on this, I'd be happy to review a PR.

@guanqun
Copy link

guanqun commented Aug 30, 2018

I can take a look at this issue, but I've one question, as we have a CLI option to specify the max heap pages, when user specifies this option, should we ignore the "heapsize" on the chain?

@vs77bb
Copy link

vs77bb commented Sep 10, 2018

@guanqun We've paid out the bounty for this issue to you via tip. Please let us know if you have any issues claiming, and great work!

@guanqun
Copy link

guanqun commented Sep 11, 2018

Thanks @vs77bb I'm not exactly sure how to claim that... Will try to figure this out.

JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this issue Apr 21, 2021
liuchengxu added a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
liuchengxu pushed a commit to autonomys/substrate that referenced this issue Jun 3, 2022
…t-timeout

Increase block request timeout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants