Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached cargo-install #2057

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Use cached cargo-install #2057

merged 3 commits into from
Feb 17, 2022

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Feb 17, 2022

I assumed @tomaka didn't like cargo-nextest so not suggesting it here.
Here you go, 1sec instead of 2 min
image

@TriplEight TriplEight requested a review from tomaka February 17, 2022 16:01
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

Copy link
Contributor

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tomaka
Copy link
Contributor

tomaka commented Feb 17, 2022

I assumed @tomaka didn't like cargo-nextest so not suggesting it here.

That's not true. I'm cautious against being overly reliant on tools like this, not avoiding using them. For example parsing the programmatic output of cargo nextest wouldn't be a good idea.

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Feb 17, 2022
@TriplEight
Copy link
Contributor Author

just nagging you there :)

For example parsing

yes, indeed, but do you parse it?

@mergify mergify bot merged commit cda79af into main Feb 17, 2022
@mergify mergify bot deleted the 3x8_ci_impr branch February 17, 2022 16:21
@tomaka
Copy link
Contributor

tomaka commented Feb 17, 2022

What I mean is that if cargo nextest happened to be abandoned over night, we should be able to switch back to cargo test easily. If we were analyzing the output of cargo nextest and performing important actions depending on the result, we would lose the possibility to easily switch back to cargo test.

@TriplEight
Copy link
Contributor Author

yeah, this is a normal concern, but considering how rarely we end up parsing i.e. test outputs I think it's worth discussing this probability when we're about to parse some outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants