Take into account size as well in weight limiting. #7369

eskimor · 2023-06-14T14:38:19Z

To avoid oversized blocks as well. We already have weight limiting in place, by using the proof_size component of weight to track block usage we can use all the existing logic to limit the size of the block equally as time weights.

Also get rid of randomized selection in provisioner as all production chains already support prioritized selection. This simplifies the runtime code a bit and is no longer properly supported as of the code unification (enter/create_inherent) PR.

Tests
Run benchmarks
Sanity check weights

No longer supported by runtime.

Random filtering of remote disputes got dropped.

eskimor · 2023-06-28T16:43:46Z

bot bench $ runtime polkadot runtime_parachains::paras_inherent
bot bench $ runtime westend runtime_parachains::paras_inherent
bot bench $ runtime rococo runtime_parachains::paras_inherent
bot bench $ runtime kusama runtime_parachains::paras_inherent

command-bot · 2023-06-28T16:43:52Z

@eskimor https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088040 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-af05bab2-000e-41d7-9171-2ceb31ddc5d0 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-06-28T16:43:56Z

@eskimor https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088041 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-5294ff2b-c257-4417-bfb8-3ca9bc8a40b4 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-06-28T16:44:00Z

@eskimor https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088044 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras_inherent. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-197b9ad5-1bc3-4c3c-b2ad-a70512112c7b to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-06-28T16:44:05Z

@eskimor https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088045 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-fc417baa-2540-4ab9-b785-9c7c78bd60ab to cancel this command or bot cancel to cancel all commands in this pull request.

…HEAD

command-bot · 2023-06-28T18:08:50Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088044 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088044/artifacts/download.

…ains::paras_inherent

command-bot · 2023-06-28T18:35:32Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088045 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088045/artifacts/download.

command-bot · 2023-06-28T18:38:41Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088041 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088041/artifacts/download.

command-bot · 2023-06-28T18:39:57Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088040 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3088040/artifacts/download.

eskimor · 2023-06-28T22:51:00Z

bot bench $ runtime polkadot runtime_parachains::paras_inherent
bot bench $ runtime westend runtime_parachains::paras_inherent
bot bench $ runtime rococo runtime_parachains::paras_inherent

command-bot · 2023-06-28T22:51:06Z

@eskimor https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3089256 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-87388d61-fede-4d46-95c5-1d44ee68b169 to cancel this command or bot cancel to cancel all commands in this pull request.

…chains::paras_inherent

command-bot · 2023-06-29T00:42:42Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3089256 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3089256/artifacts/download.

command-bot · 2023-06-29T00:45:14Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3089257 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3089257/artifacts/download.

eskimor · 2023-06-29T07:55:43Z

bot bench $ runtime westend runtime_parachains::paras_inherent
bot bench $ runtime rococo runtime_parachains::paras_inherent

command-bot · 2023-06-29T07:55:48Z

@eskimor https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3090231 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-1fbfca47-7f1b-4972-8718-77964bdec9e5 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-06-29T07:55:53Z

@eskimor https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3090232 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras_inherent. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-8a51bf3c-363e-4a64-b735-2d62f1c68bc6 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-06-29T09:24:10Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3090232 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3090232/artifacts/download.

…hains::paras_inherent

command-bot · 2023-06-29T09:49:21Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3090231 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3090231/artifacts/download.

eskimor · 2023-06-29T13:50:05Z

bot bench $ runtime rococo runtime_parachains::paras_inherent

command-bot · 2023-06-29T13:50:10Z

@eskimor https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3091553 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras_inherent. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-e361ab08-e661-4a8d-9617-ba9e090db8ae to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-06-29T15:17:11Z

@eskimor Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime rococo runtime_parachains::paras_inherent has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3091553 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3091553/artifacts/download.

runtime/parachains/src/paras_inherent/mod.rs

slumber

Clean PR, thanks!

runtime/parachains/Cargo.toml

runtime/parachains/src/paras_inherent/mod.rs

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

Co-authored-by: Chris Sosnin <48099298+slumber@users.noreply.github.com>

tdimitrov · 2023-07-13T18:12:16Z

I did a burn in today. Runtime version: 0.9.41-e2eddbecf7a

Before running disputes (new images were fully deployed around 14:00 UTC):

After enabling disputes:

Additionally I saw a spike in relay chain block times:

And a finality lag around 60 blocks:

Also I noticed some errors in the logs:

15:12:24.721 ERROR tokio-runtime-worker parachain::candidate-backing: Failed to validate and make available: ValidationFailed(ValidationFailed("Check Validation Outputs: Bad request"))

I'm not sure if they are related to the test or to the past runtime upgrades.

EDIT: The results above are without updating the runtime.

tdimitrov · 2023-07-17T13:48:03Z

I've discussed the results with @ordian and @sandreim and understood that my expectations are not correct. Bigger block times and finality lag is expected during disputes and the values above are acceptable.

I ran another test today. What I did:

Deployed master and enabled disputes to get some baseline results.
Disabled disputes to make sure the network recovers ✔️
Reenabled disputes again and deployed this PR - no significant change in the results.
Performed runtime upgrade with a binary from this PR - again no significant change in results.
Disabled disputes to make sure the network recovers ✔️

The results:

Some timestamps (times are in UTC on Jul 17th):

07:45 - initiated disputes with master deployed
10:30 - PR deployed on all nodes
11:27 - Disputes stopped to check recovery
11:45 - Network fully recovered
11:53 - Enabled disputes again
12:33 - Runtime upgrade
13:15 - Disputes stopped (and network recovered)

There are some outliers in terms of block import times but the node count is not too much - 2 to 6 nodes most of the time, one slot with around 50 nodes.

I think it's safe to merge.

eskimor · 2023-08-01T12:43:46Z

bot merge

* Take into account size as well in weight limiting. * Fix logging. * More logs. * Remove randomized selection in provisioner No longer supported by runtime. * Fix and simplify weight calculation. Random filtering of remote disputes got dropped. * Make existing tests pass. * Tests for size limiting. * Fix provisioner. * Remove rand dependency. * Better default block length for tests. * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent * Update runtime/parachains/src/paras_inherent/mod.rs Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> * Update runtime/parachains/src/paras_inherent/mod.rs Co-authored-by: Chris Sosnin <48099298+slumber@users.noreply.github.com> * Add back missing line. * Fix test. * fmt fix. * Add missing test annotation --------- Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: command-bot <> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> Co-authored-by: Chris Sosnin <48099298+slumber@users.noreply.github.com>

Take into account size as well in weight limiting.

d9328bb

Fix logging.

b0b281f

eskimor force-pushed the rk-weight-size branch from 6d014a9 to b0b281f Compare June 14, 2023 15:52

eskimor added 8 commits June 15, 2023 10:43

More logs.

3f2a64d

Remove randomized selection in provisioner

78759a6

No longer supported by runtime.

Fix and simplify weight calculation.

3944eae

Random filtering of remote disputes got dropped.

Make existing tests pass.

df97ef7

Tests for size limiting.

e715709

Fix provisioner.

8f35e43

Remove rand dependency.

a2a8a20

Better default block length for tests.

92ac4aa

Merge branch 'master' of https://github.com/paritytech/polkadot into …

76d1ff9

…HEAD

eskimor requested review from tdimitrov and slumber June 28, 2023 17:11

".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parach…

46c318c

…ains::paras_inherent

".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_para…

ae551df

…chains::paras_inherent

".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parac…

d6c13d9

…hains::paras_inherent

tdimitrov reviewed Jul 4, 2023

View reviewed changes

runtime/parachains/src/paras_inherent/mod.rs Outdated Show resolved Hide resolved

tdimitrov approved these changes Jul 4, 2023

View reviewed changes

slumber approved these changes Jul 4, 2023

View reviewed changes

runtime/parachains/Cargo.toml Outdated Show resolved Hide resolved

runtime/parachains/src/paras_inherent/mod.rs Outdated Show resolved Hide resolved

runtime/parachains/src/paras_inherent/mod.rs Show resolved Hide resolved

eskimor and others added 5 commits July 4, 2023 16:31

Update runtime/parachains/src/paras_inherent/mod.rs

741cf8c

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

Update runtime/parachains/src/paras_inherent/mod.rs

0ca82a4

Co-authored-by: Chris Sosnin <48099298+slumber@users.noreply.github.com>

Add back missing line.

35797aa

Merge branch 'master' into rk-weight-size

be1037f

Merge branch 'master' into rk-weight-size

59d6dce

eskimor added 4 commits August 1, 2023 09:41

Merge branch 'master' into rk-weight-size

52f87f3

Fix test.

99f7ca5

fmt fix.

6a0c072

Add missing test annotation

8885afe

paritytech-processbot bot merged commit ff5f602 into master Aug 1, 2023

paritytech-processbot bot deleted the rk-weight-size branch August 1, 2023 12:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Take into account size as well in weight limiting. #7369

Take into account size as well in weight limiting. #7369

eskimor commented Jun 14, 2023 •

edited

Loading

eskimor commented Jun 28, 2023

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 28, 2023

command-bot bot commented Jun 28, 2023

command-bot bot commented Jun 28, 2023

command-bot bot commented Jun 28, 2023

eskimor commented Jun 28, 2023

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 29, 2023

command-bot bot commented Jun 29, 2023

eskimor commented Jun 29, 2023

command-bot bot commented Jun 29, 2023 •

edited

Loading

command-bot bot commented Jun 29, 2023 •

edited

Loading

command-bot bot commented Jun 29, 2023

command-bot bot commented Jun 29, 2023

eskimor commented Jun 29, 2023

command-bot bot commented Jun 29, 2023 •

edited

Loading

command-bot bot commented Jun 29, 2023

slumber left a comment

tdimitrov commented Jul 13, 2023 •

edited

Loading

tdimitrov commented Jul 17, 2023 •

edited

Loading

eskimor commented Aug 1, 2023

Take into account size as well in weight limiting. #7369

Take into account size as well in weight limiting. #7369

Conversation

eskimor commented Jun 14, 2023 • edited Loading

eskimor commented Jun 28, 2023

command-bot bot commented Jun 28, 2023 • edited Loading

command-bot bot commented Jun 28, 2023 • edited Loading

command-bot bot commented Jun 28, 2023 • edited Loading

command-bot bot commented Jun 28, 2023 • edited Loading

command-bot bot commented Jun 28, 2023

command-bot bot commented Jun 28, 2023

command-bot bot commented Jun 28, 2023

command-bot bot commented Jun 28, 2023

eskimor commented Jun 28, 2023

command-bot bot commented Jun 28, 2023 • edited Loading

command-bot bot commented Jun 29, 2023

command-bot bot commented Jun 29, 2023

eskimor commented Jun 29, 2023

command-bot bot commented Jun 29, 2023 • edited Loading

command-bot bot commented Jun 29, 2023 • edited Loading

command-bot bot commented Jun 29, 2023

command-bot bot commented Jun 29, 2023

eskimor commented Jun 29, 2023

command-bot bot commented Jun 29, 2023 • edited Loading

command-bot bot commented Jun 29, 2023

slumber left a comment

Choose a reason for hiding this comment

tdimitrov commented Jul 13, 2023 • edited Loading

tdimitrov commented Jul 17, 2023 • edited Loading

eskimor commented Aug 1, 2023

eskimor commented Jun 14, 2023 •

edited

Loading

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 28, 2023 •

edited

Loading

command-bot bot commented Jun 29, 2023 •

edited

Loading

command-bot bot commented Jun 29, 2023 •

edited

Loading

command-bot bot commented Jun 29, 2023 •

edited

Loading

tdimitrov commented Jul 13, 2023 •

edited

Loading

tdimitrov commented Jul 17, 2023 •

edited

Loading