Clamp benchmark ranks to respect MaxRank #7720
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7517
Issues
1. Compile-Time vs Runtime Rank Mismatch
promote_fast
Benchmark uses mock runtime'sMaxRank
during benchmark generation while allowing runtime overrides. Creating potential parameter mismatch between benchmark metadata(i.e. generatedr
values) and runtime configuration(i.e.T::MaxRank
).2. Static Rank Assumptions
bump_demote
Benchmark initialized members at rank 2, making it incompatible withMaxRank=1
configurationspromote
Benchmark contained hardcoded rank values (1 → 2) which fails forMaxRank=1
Changes
Dynamic Rank Clamping