add genesis presets for glutton westend

[clangenb]

Extracted from #7473.

Part of: #5704.

[clangenb]

/cmd prdoc --audience runtime_dev --bump minor

[bkontur]

@clangenb also please clean cumulus/polkadot-parchain/src/chain_spec/glutton.rs

[clangenb]

@clangenb also please clean cumulus/polkadot-parchain/src/chain_spec/glutton.rs

Hmm, I don't think this is a good idea, polkadot-parachain-bin CLI wants to extract the para-id from the command, see

polkadot-sdk/cumulus/polkadot-parachain/src/chain_spec/mod.rs

Line 155 in e8d17cb

para_id.expect("Must specify parachain id"),

.

But we can't do this with the genesis presets, as the para-id is hardcoded. So I think I should only clean this up, if we decide to remove the option for passing custom para-ids from the CLI. What is your take on this?

[bkontur]

@clangenb also please clean cumulus/polkadot-parchain/src/chain_spec/glutton.rs

Hmm, I don't think this is a good idea, polkadot-parachain-bin CLI wants to extract the para-id from the command, see

polkadot-sdk/cumulus/polkadot-parachain/src/chain_spec/mod.rs

Line 155 in e8d17cb

para_id.expect("Must specify parachain id"),

.

But we can't do this with the genesis presets, as the para-id is hardcoded. So I think I should only clean this up, if we decide to remove the option for passing custom para-ids from the CLI. What is your take on this?

I see, so you don't need to use .with_genesis_config_preset_name(sp_genesis_builder::LOCAL_TESTNET_RUNTIME_PRESET), but you can still use

.with_genesis_config_patch(glutton_westend_runtime::genesis_config_presets::glutton_westend_genesis(
		para_id,
		vec![Sr25519Keyring::Alice.public().into()],
	))

at least we will use one source of this genesis, and it should be ok, while we are referencing the glutton_westend_runtime::WASM_BINARY above.

[clangenb]

Ahh, damn you are right. I could have thought of this too. Thanks. 🚀

[clangenb]

/cmd prdoc --audience runtime_dev --bump minor

[github-actions]

Command "prdoc --audience runtime_dev --bump minor" has failed ❌! See logs here

[clangenb]

/cmd prdoc --audience runtime_dev --bump minor --force

[clangenb]

PR is ready for more reviews. 🚀

[seadanda]

We're aiming to deprecate the use of polkadot-parachain with its hardcoded list of runtimes in favour of the omni-node anyway, which just takes the runtime wasm and other configs as arguments. You always need to recompile the wasm to change the para id in the presets though.

[clangenb]

Cool, thanks for the reviews! I guess we can add this to the merge queue if someone could add a label?

[bkchr]

Why are you not using the preset here? Why are you calling the code from the runtime here?

[clangenb]

Because the current implementation wants to pass the para-id from the CLI, but the presets have a hardcoded para-id (see above discussion). If this is no longer the desired behaviour I am happy to change it.

Only glutton has this behaviour, and I remember that some wanted to launch many gluttons on one relay chain for stress testing. So I thought it should remain like that.

[bkchr]

I just saw the comments above. Maybe we need some with_genesis_config_patch_and_preset.

CC @michalkucharczyk

[michalkucharczyk]

Yeah, ideally if presets/more patches could be stacked.

But also GenesisConfigBuilderRuntimeCaller::get_named_preset could be called to get preset from wasm, and then simply merge the patch:

crate::json_patch::merge(&mut config, json!({... para_id}));

And use merged output in ChainSpecBuilder::with_genesis_config_patch.

That flow would avoid call into the native runtime.

[bkchr]

/tip medium

[substrate-tip-bot]

@bkchr A referendum for a medium (80 DOT) tip was successfully submitted for @clangenb (16YCL3UVpVWQLGW3p3Zx4k5WAEp9W1DwdDnxAbyAaPxVxnp3 on polkadot).

Referendum number: 1461.

[substrate-tip-bot]

The referendum has appeared on Polkassembly.