Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #7383 #7392

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link
Contributor

Backport #7383 into stable2409 from bkontur.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7383-to-stable2409
git worktree add --checkout .worktree/backport-7383-to-stable2409 backport-7383-to-stable2409
cd .worktree/backport-7383-to-stable2409
git reset --hard HEAD^
git cherry-pick -x ada12be652a4fa8f60fc54e8cfe9ca81e09ad28b
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 29, 2025
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

This PR contains small fixes and backwards compatibility issues
identified during work on the larger PR:
#6906.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit ada12be)
@bkontur bkontur force-pushed the backport-7383-to-stable2409 branch from 1e69297 to e06d981 Compare January 29, 2025 21:45
@bkontur bkontur marked this pull request as ready for review January 29, 2025 21:46
bkontur
bkontur previously approved these changes Jan 29, 2025
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: check-tracing
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8115652

@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 29, 2025 21:52
@bkontur bkontur enabled auto-merge (squash) January 29, 2025 21:57
@EgorPopelyaev EgorPopelyaev merged commit 5628190 into stable2409 Feb 4, 2025
158 of 189 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7383-to-stable2409 branch February 4, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants