Full Unbond in Staking #3811
Full Unbond in Staking #3811
Conversation
|
@Ank4n according to @kianenigma we want to fully unbond everything after chilling. Therefore, the extrinsic don't need to take any value, also there will be no need to add a check for minimum active bond which you suggested earlier here. #3629 (comment) Also, if we want to do a chill also when we expect a value, we can definitely do that in the unbond extrinsic. should i go ahead and include that? |
|
@kianenigma wdyt about |
This is also fine with me, no strong opinion. I like your idea better as it improves UX without wallets needing to do much. |
|
OK. So, should we still keep the full unbond extrinsic and also implement the implicit one that @Ank4n is suggesting? |
dharjeezy
requested review from
athei,
acatangiu,
andresilva,
sorpaas,
cheme,
a team and
koute
as code owners
dharjeezy
force-pushed
the
dami/full_unbond
branch
from
f6032b7 to
df5c186
Compare
# Conflicts: # polkadot/runtime/westend/src/weights/pallet_staking.rs # substrate/frame/staking/src/benchmarking.rs # substrate/frame/staking/src/pallet/impls.rs # substrate/frame/staking/src/pallet/mod.rs # substrate/frame/staking/src/weights.rs
# Conflicts: # Cargo.lock
|
@Ank4n @kianenigma please help review again |
…re unbonding all amount
|
@Ank4n can we get this merged? |
There was a problem hiding this comment.
This path (nomination-pools/test-transfer-stake/) does not exist anymore in master. Should be cleaned up.
There was a problem hiding this comment.
i have cleaned this up now
Reaching out to few more folks to try and get the additional review. |
There was a problem hiding this comment.
Good work @dharjeezy and thank you for the contribution.
One small question from me and I am ready to approve.
| Event::Unbonded { stash: 11, amount: 1000 } | ||
| ] | ||
| )); | ||
| }) |
|
@dharjeezy it looks like some tests are failing. Could you take a look? |
# Conflicts: # substrate/frame/staking/src/pallet/impls.rs
i have addressed this |
|
bot fmt |
|
@Ank4n https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8297709 was started for your command Comment |
|
@Ank4n Command |
closes #414
Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW