-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct target dir in polkadot readme #1643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this. Maybe @wentelteefje or someone from the @paritytech/docs-audit can jump in as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl https://getsubstrate.io -sSf | bash -s -- --fast
DQ but do you know where / how this is maintained? It mentions the old Substrate repo in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea. In the substrate README we are linking to https://docs.substrate.io/install/, which is probably a good idea here too, since the build environment and requirements for polkadot should not be different from what is described there. This getsubstrate stuff can be removed then.
I updated the readme and removed a lot of outdated stuff.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this cleanup was much needed.
What's the rationale behind deleting |
Its not needed anymore. Standard rust stable should be enough. But yea, the other places should be fixed. |
Closes paritytech#1372 This fixes the target directories in the polkadot readme. I verified manually the Ubuntu based install works on a fresh cloud machine. Build from source also worked as described. Since paritytech#1304 landed `--dev` also works again (not on v1.1.0 though), so I would consider the install instructions fixed.
Closes #1372
This fixes the target directories in the polkadot readme. I verified manually the Ubuntu based install works on a fresh cloud machine. Build from source also worked as described.
Since #1304 landed
--dev
also works again (not on v1.1.0 though), so I would consider the install instructions fixed.