Handle CollationSeconded Logs Conditionally
#1475
Conversation
|
We could also just drop it instead of duplicating code (if others agree) |
|
@slumber is right. This isn't a V1/VStaging difference. You could write a V1 collator which didn't rely on receiving The logic change needed is to expect a |
|
We have three variables.
We want to warn when (3) is true and (1) is false. We don't want to warn when (1), (3) are true but (2) is false. We don't want to warn when (1) and (3) are true in general. I hope this is clear now. |
BradleyOlson64
changed the title
CollationSeconded Logs Conditionally
| ); | ||
| }, | ||
| None => { | ||
| gum::debug!( |
There was a problem hiding this comment.
I'd make this a warning, usually a mismatch here is likely a bug.
There was a problem hiding this comment.
debug! logs are often for bugs, just not critical ones.
|
bot merge |
|
@rphmeier Unknown command "merge". Refer to help docs and/or source code. |
* Removing unnecessary log * Drop unneeded log * Handling logs conditionally * Changing unexpected message to warn * Back to debug * fmt
* store both block number and hash in BestFinalized * also fix relay code * spelling
Separating the VStaging message handling case from V1 made the most sense to me. Let me know if there was a more concise way!
Closes #1469