XCM bridge hub pallet (will be deployed at bridge hubs) #2213

svyatonik · 2023-06-16T10:14:02Z

related to #2451

There's a lot of work here, but I'd like to do something in a separate PR. Opening PR early for visibility and to avoid losing it accidentally (because it'll take at least couple of weeks to solve and test everything).

Important things here:

we can't use cumulus code directly from the pallet directly (before we'll move everything to a monorepo?), so either this pallet goes to the Cumulus repo OR we'll use some abstractions. I'll yet to think about that Looks like we don't need anything explicit from cumulus, but I'll double check during polishing
I assume we can have some collisions for the lane id generation mechanism, because lane id is just 4 bytes. I'd start with accepting this risk and change LaneId to some abstract LaneKey in the future. We'll use ordered pair of bridge side locations as this key. Ordered means that on both sides of the bridge we need to generate the same key. So we can't use simply (source, destination) here Decided to fix it first in to avoid unnecessary complexities - Change LaneId underlying type from [u8; 4] to H256 #2221;
the main reason why I'm opening this PR early is that we need to make some changes to the messages pallet. In particular, we won't assume that all lanes are opened - it'll be managed externally (by the pallet from this PR). So we need to check lane state before sending/accepting messages

…ommit

…llets for dynamic lanes/fees support. One will be deployed at the bridge hub (xcm-bridge-hub) and another one (xcm-bridge-hub-router) at sibling/parent chains to send messages to remote network over the bridge hub

…locations where possible

svyatonik · 2023-07-14T06:20:32Z

modules/xcm-bridge-hub/src/lib.rs

+		/// to return to regular bridge operations.
+		#[pallet::call_index(2)]
+		#[pallet::weight(Weight::zero())] // TODO: https://github.com/paritytech/parity-bridges-common/issues/1760 - weights
+		pub fn report_misbehavior(


Two things to add:

if Implement additional require primitives for dynamic fees directly for pallet-xcm-bridge-hub #2261 will be implemented, we'll probably just remove this function or at least the current misbehavior. That's because it will be a sending chain problem to deal with its own queue/storage. Let's keep it for now, though, until we have a confidence that Implement additional require primitives for dynamic fees directly for pallet-xcm-bridge-hub #2261 is the right option;

there's currently a problem - if bridge is closed at one side and misbehaving at other, the messages and the bridge remains will live here forever. I'll deal with that in a follow up PRs - that is noted here under the " start closing lane at this side if the same lane is in closing state at the bridged side" point

If we are not sure about the misbehavior part yet, could we keep in this PR only the open-close bridge part ? And move the misbehavior to #2261 ? Or to a separate PR anyway ?

To me it seems easier to review and merge this way.

Right! It doesn't belong actually to #2261, because it isn't about dynamic fees, it just depends on the way our low-level transport works. So separate PR (on top of this one) looks good - I'll extract those two calls (report_misbehavior and resume_misbehaving_bridges) soon. Thanks for suggestion

…rmat will likely change to be able to resume bridges from the on_iniitalize/on_idle

serban300 · 2023-07-14T09:10:02Z

primitives/xcm-bridge-hub/src/lib.rs

+///
+/// Returns error if `bridge_origin_relative_location` is outside of `here_universal_location`
+/// local consensus OR if `bridge_destination_universal_location` is not a universal location.
+pub fn bridge_locations(


Nit: I would define this on the BridgeLocations struct.

It isn't trivial and I'm in favor of having easier "constructors", so left it as a free function

modules/xcm-bridge-hub/src/lib.rs

primitives/xcm-bridge-hub/src/lib.rs

) * Adjust commands * Use `NetworkWorker::next_action()` instead of `poll()` * rustfmt * minor: fix mutability * Move imports * Replace `NetworkWorker::next_action()` with `run()` * Import fix * Make `NetworkWorker::run` consume self * Retire `OldV1SessionInfo` * update lockfile for {"polkadot", "substrate"} * update lockfile for {"substrate", "polkadot"} * update lockfile for {"substrate", "polkadot"} * Make stuff compile Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Piotr Mikołajczyk <piomiko41@gmail.com> Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: parity-processbot <> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* XCM over bridge pallet (won't ever be merged to this repo): initial commit * try both bridge-id and lane-id * flush * flush * flush * flush * first prototype * started working on xcm-over-bridge tests * proper open_bridge_works test * more open_bridge tests * request_bridge_closure tests * tests for close_bridge * report_misbehavior tests * renaming xcm-over-bridge ad xcm-bridge-hub: we'll have two similar pallets for dynamic lanes/fees support. One will be deployed at the bridge hub (xcm-bridge-hub) and another one (xcm-bridge-hub-router) at sibling/parent chains to send messages to remote network over the bridge hub * added couple of TODOs * moved BridgeQueuesState here + TODO for implementing report_bridge_queues_state + fmt * fixing TODOs * fixing TODOs * moved bridge locations to primitives * added a couple of TODOs * ref issue from TODO * clippy and spelling * fix tests * another TODOs * typo * LaneState -> force_close_bridge * start_closing_the_bridge -> start_closing_bridge * removed Closing bridge state, so now we only have the Opened -> optional temporary Closed state -> None * spelling * started prototyping suspend+resume on misbehavior * continue prototyping * more tests for open_bridge * more tests for close_bridge * more tests for report_misbehavior * started tests for resume_misbehaving_bridges * implemented tests for resume_misbehaving_bridges * remove UnsuspendedChannelWithMisbehavingOwner because now, when all bridges are resumed at once + we assume that the inbound XCM channel is suspended immediately it is no longer actual * added TODO * add comment re misbehavior reporter if he's associated with the bridge owner * ignored clippy * fmt * use versioned XCM structs in public interfaces and storage + Box XCM locations where possible * spelling * removed TODO in favor of #2257 * LocalChannelManager -> LocalXcmChannelManager * removed code specific to #2233, because it isn't the only option now * removemisbehavior mentions * also temporary (?) remove BridgesByLocalOrigin because the storage format will likely change to be able to resume bridges from the on_iniitalize/on_idle * AllowedOpenBridgeOrigin -> OpenBridgeOrigin * - TooManyBridgesForLocalOrigin * use bridge_destination_relative_location in args * better impl of strip_low_level_junctions * get rid of xcm_into_latest * clippy * added #![warn(missing_docs)] to new crates

XCM over bridge pallet (won't ever be merged to this repo): initial c…

547b9e4

…ommit

svyatonik added P-Runtime PR-audit-needed A PR has to be audited before going live. labels Jun 16, 2023

svyatonik added this to the Kusama <> Polkadot Parachain Bridge V2 milestone Jun 16, 2023

svyatonik self-assigned this Jun 16, 2023

This was referenced Aug 25, 2023

Make pallets XCM compatible + less configuration overhead #2457

Open

Add state to message lanes #2214

Merged

try both bridge-id and lane-id

e47c7a2

svyatonik mentioned this pull request Jun 20, 2023

Change LaneId underlying type from [u8; 4] to H256 #2221

Merged

3 tasks

svyatonik added 2 commits June 21, 2023 08:54

Merge branch 'master' into xcm-over-bridge

6dc203c

flush

6afea0f

svyatonik mentioned this pull request Jun 21, 2023

Bump Substrate, Polkadot and Cumulus #2223

Merged

svyatonik added 11 commits June 21, 2023 16:23

flush

98bd375

flush

cef120d

flush

a36fb70

Merge branch 'master' into xcm-over-bridge

e58b1b3

first prototype

63b921e

started working on xcm-over-bridge tests

028e3fe

proper open_bridge_works test

1633b1f

more open_bridge tests

95be214

request_bridge_closure tests

9d2834a

tests for close_bridge

61c4b79

report_misbehavior tests

d2a466a

svyatonik mentioned this pull request Jun 23, 2023

Introduce MessagesLaneManager #2227

Merged

svyatonik changed the title ~~XCM over bridge pallet (very WIP)~~ XCM over bridge pallet Jun 26, 2023

This was referenced Aug 25, 2023

Adapt relayer to work with dynamic lanes #2407

Open

Dynamic fees implementation that reports bridge queues state to the sending chain (backup option) #2233

Closed

svyatonik changed the title ~~XCM over bridge pallet~~ XCM bridge hub pallet (will be deployed at bridge hubs) Jun 30, 2023

added couple of TODOs

5ff26d2

svyatonik added 2 commits July 11, 2023 15:39

use versioned XCM structs in public interfaces and storage + Box XCM …

86fbb66

…locations where possible

spelling

c8ae512

svyatonik mentioned this pull request Jul 11, 2023

Allow delivery confirmations on closed outbound lanes #2257

Merged

removed TODO in favor of #2257

7e06e4b

svyatonik mentioned this pull request Jul 13, 2023

Implement additional require primitives for dynamic fees directly for pallet-xcm-bridge-hub #2261

Merged

3 tasks

svyatonik added 3 commits July 13, 2023 17:08

LocalChannelManager -> LocalXcmChannelManager

64c1a58

Merge branch 'master' into xcm-over-bridge

1717586

removed code specific to #2233, because it isn't the only option now

5d7c5dc

svyatonik mentioned this pull request Jul 13, 2023

Introduce partial bp-xcm-bridge-hub - just LocalXcmChannelManager #2265

Merged

svyatonik commented Jul 14, 2023

View reviewed changes

removemisbehavior mentions

0052848

svyatonik mentioned this pull request Jul 14, 2023

Misbehavior in the xcm-bridge-hub pallet #2268

Closed

also temporary (?) remove BridgesByLocalOrigin because the storage fo…

bdd7ae1

…rmat will likely change to be able to resume bridges from the on_iniitalize/on_idle

serban300 reviewed Jul 17, 2023

View reviewed changes

svyatonik added 7 commits July 17, 2023 09:53

AllowedOpenBridgeOrigin -> OpenBridgeOrigin

37f11e8

- TooManyBridgesForLocalOrigin

c25620f

use bridge_destination_relative_location in args

d10d884

better impl of strip_low_level_junctions

2776244

get rid of xcm_into_latest

941c628

Merge branch 'master' into xcm-over-bridge

ccf5824

clippy

3d35a17

serban300 approved these changes Jul 17, 2023

View reviewed changes

svyatonik added 2 commits July 17, 2023 12:27

added #![warn(missing_docs)] to new crates

a88916e

Merge branch 'master' into xcm-over-bridge

5afc4ab

acatangiu approved these changes Jul 17, 2023

View reviewed changes

svyatonik merged commit f9cba27 into master Jul 17, 2023

svyatonik deleted the xcm-over-bridge branch July 17, 2023 09:50

svyatonik mentioned this pull request Aug 25, 2023

[V2 Bridges] Dynamic way of adding permissionless lanes (bridges between parachains) #2451

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XCM bridge hub pallet (will be deployed at bridge hubs) #2213

XCM bridge hub pallet (will be deployed at bridge hubs) #2213

svyatonik commented Jun 16, 2023 •

edited

Loading

svyatonik Jul 14, 2023

serban300 Jul 14, 2023

svyatonik Jul 14, 2023

svyatonik Jul 14, 2023

serban300 Jul 14, 2023

svyatonik Jul 17, 2023

XCM bridge hub pallet (will be deployed at bridge hubs) #2213

XCM bridge hub pallet (will be deployed at bridge hubs) #2213

Conversation

svyatonik commented Jun 16, 2023 • edited Loading

svyatonik Jul 14, 2023

Choose a reason for hiding this comment

serban300 Jul 14, 2023

Choose a reason for hiding this comment

svyatonik Jul 14, 2023

Choose a reason for hiding this comment

svyatonik Jul 14, 2023

Choose a reason for hiding this comment

serban300 Jul 14, 2023

Choose a reason for hiding this comment

svyatonik Jul 17, 2023

Choose a reason for hiding this comment

svyatonik commented Jun 16, 2023 •

edited

Loading