Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable benchmarking all pallets for a given runtime with bench-all #57

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

seadanda
Copy link
Contributor

Add a runtime parameter to bench-all to allow benchmarking all pallets for a given runtime with one command

@seadanda seadanda self-assigned this Nov 14, 2023
@seadanda seadanda added the enhancement New feature or request label Nov 14, 2023
@seadanda
Copy link
Contributor Author

@mordamax I created this but for some reason the artifacts that are generated when it runs does not include a diff, only json output. Am I missing something?

@mordamax
Copy link
Collaborator

@seadanda could you please share the pipeline for the context? thx

@seadanda
Copy link
Contributor Author

@seadanda could you please share the pipeline for the context? thx

Ah I cleaned it and just used the individual bench scripts, I'm working on a branch for coretime, so I'll run it on that and update here when I have the artifacts to show you.

@seadanda
Copy link
Contributor Author

@mordamax I realised that I sent the job link to someone in element, so I've got the job I ran for paritytech/polkadot-sdk#2024 here: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4238416

@mordamax
Copy link
Collaborator

@seadanda could you please resolve conflicts?

@mordamax I realised that I sent the job link to someone in element, so I've got the job I ran for paritytech/polkadot-sdk#2024 here: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4238416

sorry, This job does not have a trace. is what it says by now

could you please re-run so I can see what you mean by only json output ?

@seadanda
Copy link
Contributor Author

I've created paritytech/polkadot-sdk#2548 and run it for glutton-westend to reproduce it on a small runtime.

@seadanda
Copy link
Contributor Author

@mordamax The bench-bot run for glutton finished and didn't show any diff, so I ran bench-all cumulus with no runtime argument to compare, but actually it doesn't return a diff either for glutton.

It did produce a diff for asset-hub-rococo, though so I ran bench bot with the runtime argument and it didn't produce a diff.

If you get a chance could you take a look please?

@mordamax
Copy link
Collaborator

@ggwpez i have no idea why that happens, may be you could help?
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4546953
image

@seadanda
Copy link
Contributor Author

seadanda commented Jan 5, 2024

Bump - sorry this is very old but has anybody got any ideas? It would be nice to merge this, but more importantly it seems that something is wrong with bench-all on main too.

@seadanda seadanda marked this pull request as ready for review January 5, 2024 17:12
@seadanda seadanda requested a review from a team as a code owner January 5, 2024 17:12
@mordamax
Copy link
Collaborator

mordamax commented Jan 5, 2024

@seadanda i've updated your branch on sdk and re-started the bench with runtime specified to see the fresh results

@seadanda
Copy link
Contributor Author

seadanda commented Jan 8, 2024

Looks like it worked: paritytech/polkadot-sdk@bd47706

Thanks for that - could we merge this in that case?

@mordamax mordamax merged commit a0a8100 into main Jan 8, 2024
@mordamax mordamax deleted the donal-bench-all-runtime-param branch January 8, 2024 15:51
@mordamax
Copy link
Collaborator

mordamax commented Jan 8, 2024

thanks for contribution @seadanda !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants