-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable benchmarking all pallets for a given runtime with bench-all #57
Conversation
@mordamax I created this but for some reason the artifacts that are generated when it runs does not include a diff, only json output. Am I missing something? |
@seadanda could you please share the pipeline for the context? thx |
Ah I cleaned it and just used the individual bench scripts, I'm working on a branch for coretime, so I'll run it on that and update here when I have the artifacts to show you. |
@mordamax I realised that I sent the job link to someone in element, so I've got the job I ran for paritytech/polkadot-sdk#2024 here: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4238416 |
@seadanda could you please resolve conflicts?
sorry, could you please re-run so I can see what you mean by |
I've created paritytech/polkadot-sdk#2548 and run it for |
@mordamax The bench-bot run for glutton finished and didn't show any diff, so I ran It did produce a diff for If you get a chance could you take a look please? |
@ggwpez i have no idea why that happens, may be you could help? |
Bump - sorry this is very old but has anybody got any ideas? It would be nice to merge this, but more importantly it seems that something is wrong with |
@seadanda i've updated your branch on sdk and re-started the bench with runtime specified to see the fresh results |
Looks like it worked: paritytech/polkadot-sdk@bd47706 Thanks for that - could we merge this in that case? |
thanks for contribution @seadanda ! |
Add a runtime parameter to bench-all to allow benchmarking all pallets for a given runtime with one command