-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
✅ Deploy Preview for capi-multisig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@peetzweg for the diff --git a/nets.ts b/nets.ts
index 05a9c15..e81c2e4 100644
--- a/nets.ts
+++ b/nets.ts
@@ -1,4 +1,4 @@
-import { net } from "capi"
+import { net } from "capi/nets"
export const westend = net.ws({
url: "wss://westend-rpc.polkadot.io/", |
Yeap, this is weird and it's related to the type declaration. Did I tweaked this manually in the package.json by rewriting the subpath export and it seems to work Created the issue paritytech/capi#1088 |
Ignoring this type issue here. In development the app does not load anymore and this error Rune related error shows up in the console. ![]() |
This is to be expected (only by us, that is, seeing as we failed to let you know); as of paritytech/capi#1084 this argument is required. You can declare const scope = new Scope() at the top-level of your app, and pass that in to every run. This will ensure that all execution happen in the same scope, thus sharing cache etc. (Eventually, we'll likely make a
Once you pass in a |
I think solving it in a "react" library down the line is quite far away, making this use very cumbersome. How about setting a "defaultScope" for all Runes in a static way and just pass an override scope on a per rune basis? Haven't looked into the details of the scope but feels like something which is not changing too often in the lifecylce of an app, or is it? |
I'm not sure how you define quite far away, but I could see working on such a library before v0.2.0. We discussed having a default, global scope, but decided that this would be too much of a footgun, as it would be very easy to forget to pass in an override scope. |
… is only for `nets.ts`, this caused build issues as they reference each other and don't allow changes
… later somehow different 👾
Ready for review. |
For the time being, I would just pass an anonymous scope into every |
Just updated to I have not yet isolated the issue so not created a capi issue for it. Maybe it's obvious how to quickfix it? The actual extrinsic seems to have made it through though. ![]() |
i'm handling the update in a new PR. this branch is too old, don't want to fix all these conflicts |
Just resolved all conflicts minutes before. 🤷 Most of the changes are just formatting stuff anyways. Btw we have dprint and prettier in this repo. I think we should drop one of them to prevent this formatting ping pong. capi-multisig-app/www/package.json Line 29 in 30976d5
Lines 15 to 19 in 30976d5
|
wouldn't merge this version now because it produces an error with approvals and cancellations. even if the tx goes through, we can't capture the events anymore. |
capi sync
does not work as expected anymore. Had this issue already withbeta43
, any ideas how to fix this @harrysolovay ?Without
--runtime-config package.json
: