This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
rename internal components #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
force-pushed
the
bernhard-rename
branch
from
3b1ff67 to
b28d143
Compare
montekki
approved these changes
Dec 22, 2021
drahnr
force-pushed
the
bernhard-rename
branch
from
ae757f1 to
9874247
Compare
|
Hold on, I am almost done rebasing :) |
drahnr
force-pushed
the
bernhard-rename
branch
from
06e0bf0 to
05a9ca1
Compare
montekki
reviewed
Jan 14, 2022
montekki
approved these changes
Jan 18, 2022
drahnr
commented
Jan 18, 2022
Xanewok
suggested changes
Jan 18, 2022
|
The more I think about it, the more I realize how overloaded the term "server" is in the cachepot/sccache context :( This rename helps a lot but I'm still wondering if "coordinator" is a good choice here. Maybe we could use "daemon"? It's more recognizable in terms of build systems (e.g. Gradle, Buck, Bazel) and I think the benefits from being familiar with the terminology are bigger, even if our "daemon" can sometimes be ran on the foreground (not 100% technically correct). |
Co-authored-by: Igor Matuszewski <Xanewok@gmail.com>
|
The CI looks ok, I think that all review points have been addressed so merging now |
Closed
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #132
Should be merged after #131 is merged, to avoid additional friction.