Ensure named exports are prioritized over wildcard re-exports #7016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
mischnic
approved these changes
Oct 6, 2021
2 tasks
This was referenced Oct 7, 2021
3 tasks
|
@mischnic what action do I need to take to have this fix? |
|
Use any version of Parcel 2. |
|
@mischnic With regards to parcel I have below and still experiencing same error. "dependencies": { "devDependencies": { |
|
Please open a new issue with a complete code example to reproduce the error (and you didn't actually say exactly what the error is that you're getting). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6344. Fixes #6970.
The ES module spec says that named exports should be prioritized over wildcard re-exports. This updates our helpers to skip keys that are already defined when performing a wildcard re-export. This is safe because we hoist named exports to the top of the module, so by the time the helper is called, all named exports are already defined.
Previously, we either errored when trying to read the previous value (non scope-hoisting), errored when trying to re-define the property (scope hoisting with multiple re-exports), or overwrote the value with the later one (scope hoisting). Now the value is consistent across all cases.
Note: duplicate wildcard re-exports is still not fully spec compliant, but we can address this separately. According to the spec, ambiguous re-exports should be completely omitted from the namespace object, but should error when performing a named import. We currently will return the first value instead. Unfortunately, it seems most tools are inconsistent in this regard.