Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruint for conversions #3

Merged
merged 3 commits into from
Oct 15, 2022
Merged

Use ruint for conversions #3

merged 3 commits into from
Oct 15, 2022

Conversation

recmo
Copy link
Contributor

@recmo recmo commented Oct 15, 2022

No description provided.

@recmo recmo changed the title Use Ruint for conversions Use ruint for conversions Oct 15, 2022
@ziyadedher
Copy link
Contributor

ziyadedher commented Oct 15, 2022

Running some benchmarks!

Locally created a new "pyrevm-ruint" runner in evm-bench by copying the existing pyrevm runner and modifying the pyproject.toml to point to the new branch. Then ran on just those two runners: RUST_LOG=info cargo run --release -- --runners pyrevm --runners pyrevm-ruint and I get this:

pyrevm pyrevm-ruint
erc20.approval-transfer 16.8ms 16.8ms
erc20.mint 15.8ms 15ms
erc20.transfer 22.6ms 23.8ms
snailtracer 128ms 128ms
ten-thousand-hashes 17ms 17.4ms
sum 200.2ms 201ms

I don't see any significant performance changes under these benchmarks, which kinda makes sense to me since I'm not so sure that much overhead is coming from the one-time conversions. More than happy to be proven wrong here, let me know if you need a hand playing around with evm-bench or (even better) if you want to try to benchmark independently!

(not to say this PR isn't a good thing in general, just was curious if we would see a perf improvement)

@gakonst gakonst merged commit cd7bcf2 into paradigmxyz:master Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants