Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test on node 10 #71

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fix failing test on node 10 #71

merged 1 commit into from
Mar 4, 2019

Conversation

gustavnikolaj
Copy link
Collaborator

@gustavnikolaj gustavnikolaj commented Mar 4, 2019 •
edited
Loading

Adding delay before checking if destroy was called is necessary for a passing test on node.js 10.15.2.

It seems that it still works, but that it's just delayed a bit.

Fixes #70

@gustav-olsen-groupone
Add delay before checking if destroy was called.
e535564 
Necessary for a passing test on node.js 10.15.2.
@gustavnikolaj gustavnikolaj requested a review from papandreou March 4, 2019 15:18
papandreou
papandreou approved these changes Mar 4, 2019
View reviewed changes
Copy link
Owner

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, amazing, thanks a lot for working it out!

@gustavnikolaj gustavnikolaj merged commit 3663770 into master Mar 4, 2019
@gustavnikolaj gustavnikolaj deleted the fix/missingDestoryOnNode10 branch March 4, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papandreou papandreou papandreou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gustavnikolaj @papandreou @gustav-olsen-groupone