Fixed unnecessary Promise usage #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you ran `NODE_ENV=development npm test` you would get this warning from bluebird: "Warning: a promise was created in a handler but was not returned from it". This fixes that.
|
Thanks! The failing test seems unrelated to this PR, as I cannot reproduce it locally. Merging. |
papandreou
added a commit
that referenced
this pull request
Feb 5, 2016
Fixed unnecessary Promise usage
|
Released in 4.3.1, added you as a collaborator + npm owner. |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you ran
NODE_ENV=development npm testyou would get this warning from bluebird:This PR fixes that.
The problem is that if you're testing some other code that uses express-processimage, this warning bubbles up and can take quite a while to debug :)