Skip to content

Commit

Permalink
Upgrade sharp to sharp@^0.33.2 which requires dropping node 16 support
Browse files Browse the repository at this point in the history
Add Node.js 18 and 20 to CI
Related updates for images in testdata/ directory
  • Loading branch information
priyank authored and alexjeffburke committed Jan 30, 2024
1 parent 4d63702 commit bfbf5b3
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ jobs:
strategy:
matrix:
node:
- '16'
- '18'
- '20'
steps:
Expand Down Expand Up @@ -39,7 +38,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v1
with:
node-version: '16'
node-version: '18'
- name: Install dependencies
run: sudo add-apt-repository -y ppa:inkscape.dev/stable && sudo apt-get install -y optipng pngcrush pngquant graphicsmagick imagemagick libjpeg-turbo-progs inkscape libcairo2-dev libgif-dev libjpeg8-dev zlib1g-dev
- run: npm install
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.20.2
v18.19.0
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"passerror": "^1.1.1",
"pngcrush": "^3.0.0",
"pngquant": "^4.0.0",
"sharp": "^0.32.0"
"sharp": "^0.33.2"
},
"devDependencies": {
"browser-sync": "^3.0.2",
Expand Down
Binary file modified testdata/turtleCroppedAttention100x200.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified testdata/turtleCroppedEntropy100x200.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified testdata/turtleCroppedNorth.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit bfbf5b3

Please sign in to comment.