Support an engine query string parameter without arguments.

papandreou · Feb 17, 2020 · 0eafbf0 · 0eafbf0
1 parent de09f78
commit 0eafbf0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/prepareImproQueryString.js b/lib/prepareImproQueryString.js
@@ -15,7 +15,7 @@ const resizeOptions = {
 };
 
 const queryStringEngineAndArgsRegex = new RegExp(
-  `^(${Object.keys(isSupportedEngine).join('|')})=(.*)`
+  `^(${Object.keys(isSupportedEngine).join('|')})(?:=(.*))?`
 );
 
 module.exports = function prepareQueryString(queryString) {
@@ -29,7 +29,7 @@ module.exports = function prepareQueryString(queryString) {
     let m;
 
     if ((m = pair.match(queryStringEngineAndArgsRegex)) !== null) {
-      const [, engineName, engineArgs] = m;
+      const [, engineName, engineArgs = ''] = m;
       const result = [engineName];
       const splitChar = engineArgs.includes('+') ? '+' : ',';
       const remaining = engineArgs.split(splitChar);

diff --git a/test/prepareImproQueryString.js b/test/prepareImproQueryString.js
@@ -65,6 +65,10 @@ describe('prepareImproQueryString', () => {
     );
   });
 
+  it('should parse optipng with no argument', () => {
+    expect('optipng', 'when prepared to equal', 'optipng');
+  });
+
   it('should parse pngquant with integer argument correctly', () => {
     expect(
       'resize=800,800&pngquant=8',