isObject helper fails in jest

[maurolucc]

Describe the bug

fromKeyLike does not return an object (JWK). If you use the output of this function in the latest version of node you get the following error:

TypeError: JWK must be an object

To Reproduce

Use Node v15.14.0.

  const key = crypto.generateKeyPairSync("ec", {
    namedCurve: "secp256k1",
  });
  const privateJwk = await fromKeyLike(key.privateKey);
     // ^^^^^^^^^^ this is not an object
  const privateKey = await parseJwk(privateJwk, "ES256K");                                  
  // TypeError: JWK must be an object

Expected behaviour
Get proper object so as to be able to use JWK.

Environment:

• jose version: 3.11.4
• Typescript v4.2.4
• affected runtime is: Node.js v15.14.0

Additional context
If anyone faces the same issue, there are two tricks that can save you:

• Do not use privateJwk in the next function as input but {...privateJwk }
  or
• After getting privateJwk set jwk.constructor = Object;

[panva]

Hi @maurolucc, I am unable to reproduce your issue. Can you provide more details?

const crypto = require('crypto');

const { fromKeyLike } = require('jose/jwk/from_key_like');
const { parseJwk } = require('jose/jwk/parse');

const key = crypto.generateKeyPairSync("ec", {
  namedCurve: "secp256k1",
});

(async () => {
  const privateJwk = await fromKeyLike(key.privateKey);
  console.log(privateJwk.constructor)
  const privateKey = await parseJwk(privateJwk, "ES256K");
  console.log('works');
})();

❯ node -v                         
v15.14.0

❯ cat package.json | jq '.version'
"3.11.4"

❯ node some.js                    
[Function: Object]
works

[maurolucc]

Excuse me, I forgot to mention I'm using Typescript v4.2.4. Let me add it in the environment information.

[panva]

I would need the actual steps and project to reproduce then, from the top of my head i don't see how TS is relevant to this issue. As is, i'm not able to reproduce. Can you create a gist with the necessary source, configuration files, and a readme to reproduce?

[maurolucc]

Here you have: https://gist.github.com/maurolucc/a6390d6d93a2b931afaa7e349dc090ca

[panva]

@maurolucc that is of no help unfortunately. I have no clue what the package.json looks like, how you execute this, nor what the typescript configuration is.

I'm looking for a reproduction, e.g. such as that i can clone the gist, run npm i and then execute whatever command that reproduces the issue.

[maurolucc]

Alright. I've updated the gist I shared with you. Now you should be able to clone it and run:

nvm use 15.14.0
yarn
jest

You'll see that the test fails for this node version but not for older. Notice that to make this test pass in my project I fix it with the trick found in AuxTest.ts, swtiching how I return JWK:

  // returning directly privateJwk provoke getting TypeError: JWK must be an object error
  /* return {
    hexPrivateKey,
    jwk: privateJwk,
    hexPublicKey,
  }; */
  // The code below makes the trick
  return {
    hexPrivateKey,
    jwk: { ...privateJwk }, 
    hexPublicKey,
  }; 

[panva]

Thank you for the reproduction steps, very helpful!

Well, apparently under jest the global.Object comparison with constructor fails, eventho they both log as [Function: Object].

I'll update the isObject helper in to account for different domains when i have the time, unless you feel like opening a PR and researching a better way. Or possibly just making sure typeof is object and it's not null or Array, so return typeof input === 'object' && !!input && !Array.isArray(input)

[maurolucc]

@panva Awesome! You fix it already. Good job. Thanks. 😄