Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convert_init_lead_to_valid_time_lead #775

Merged
merged 23 commits into from
Aug 27, 2022

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Aug 27, 2022

Description

add convert_init_lead_to_valid_time_lead

Closes #774
Closes #380
wait for #777

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Tests added for pytest via doctest

Checklist (while developing)

  • I have added docstrings to all new functions.
  • I have commented my code, particularly in hard-to-understand areas.
  • Any new functions are added to the API. (See contribution guide)
  • CHANGELOG is updated with reference to this PR.

References

pydata/xarray#6943

@aaronspring aaronspring self-assigned this Aug 27, 2022
@github-actions
Copy link

Checkout your PR on Binder. Open the console and pip install -e . before using the notebooks to use climpred from this PR.

@aaronspring aaronspring marked this pull request as ready for review August 27, 2022 12:14
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #775 (4ad17b4) into main (dafd1f3) will decrease coverage by 1.08%.
The diff coverage is 89.47%.

❗ Current head 4ad17b4 differs from pull request most recent head 75cc63d. Consider uploading reports for the commit 75cc63d to get more accurate results

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   93.80%   92.71%   -1.09%     
==========================================
  Files          59       59              
  Lines        6235     6195      -40     
==========================================
- Hits         5849     5744     -105     
- Misses        386      451      +65     
Impacted Files Coverage Δ
climpred/horizon.py 96.55% <ø> (ø)
climpred/options.py 81.48% <ø> (ø)
climpred/tests/test_bias_removal.py 97.66% <ø> (ø)
climpred/tests/test_hindcast_prediction.py 100.00% <ø> (ø)
climpred/tests/test_logging.py 100.00% <ø> (ø)
climpred/utils.py 88.69% <68.75%> (-1.70%) ⬇️
climpred/bootstrap.py 80.52% <73.07%> (-10.36%) ⬇️
climpred/alignment.py 91.13% <73.68%> (-5.74%) ⬇️
climpred/checks.py 95.79% <83.33%> (+0.03%) ⬆️
climpred/tests/test_HindcastEnsemble_class.py 96.51% <85.71%> (-3.49%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aaronspring and others added 2 commits August 27, 2022 15:56
) (#778)

* Update test_alignment.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update classes.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update CHANGELOG.rst

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@aaronspring aaronspring merged commit 36db160 into main Aug 27, 2022
@aaronspring aaronspring deleted the convert_init_lead_to_valid_time_lead branch August 27, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant