Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Enforce verbose parameter deprecation in read_csv/read_table #57966

Merged
merged 1 commit into from
Mar 22, 2024
Merged

CLN: Enforce verbose parameter deprecation in read_csv/read_table #57966

merged 1 commit into from
Mar 22, 2024

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added Clean IO CSV read_csv, to_csv labels Mar 22, 2024
@lithomas1 lithomas1 added this to the 3.0 milestone Mar 22, 2024
@lithomas1 lithomas1 marked this pull request as ready for review March 22, 2024 18:26
@lithomas1 lithomas1 requested a review from WillAyd as a code owner March 22, 2024 18:26
@lithomas1 lithomas1 requested a review from mroeschke March 22, 2024 18:26
@mroeschke mroeschke merged commit eddd8e3 into pandas-dev:main Mar 22, 2024
51 of 54 checks passed
@mroeschke
Copy link
Member

Thanks @lithomas1

@lithomas1 lithomas1 deleted the cln-verbose-depr branch March 22, 2024 19:12
@Aloqeely
Copy link
Member

Aloqeely commented Apr 7, 2024

I have noticed that there is a test in pandas/tests/io/parser/test_unsupported.py which still checks for the deprecation warning, will open a PR soon

@Aloqeely Aloqeely mentioned this pull request Apr 7, 2024
Merged
5 tasks
@Aloqeely Aloqeely mentioned this pull request Apr 23, 2024
Open
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@lithomas1 @pmhatre1
CLN: Enforce verbose parameter deprecation in read_csv/read_table (pa…
42be6fe 
…ndas-dev#57966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@WillAyd WillAyd Awaiting requested review from WillAyd WillAyd is a code owner

Assignees
No one assigned
Labels
Clean IO CSV read_csv, to_csv
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lithomas1 @mroeschke @Aloqeely