Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: read_csv keywords: keep_date_col, delim_whitespace #57480

Closed
wants to merge 0 commits into from
Closed

DEPR: read_csv keywords: keep_date_col, delim_whitespace #57480

wants to merge 0 commits into from

Conversation

rmhowe425
Copy link
Contributor

@rmhowe425 rmhowe425 marked this pull request as draft February 18, 2024 01:34
@rmhowe425
Copy link
Contributor Author

@rhshadrach @lithomas1 I was wondering if you would be willing to take a look at the PR and let me know if I'm on the right track?

phofl
phofl reviewed Feb 18, 2024
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a lot of adjustments in the actual implementation, not only the keywords

```keep_default_na`` is not deprecated

@rmhowe425 rmhowe425 closed this Feb 18, 2024
@rmhowe425 rmhowe425 deleted the dev/depr/read_csv/keywords branch February 18, 2024 22:16
@briochh briochh mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEPR: read_csv keywords: keep_date_col, delim_whitespace
2 participants
@rmhowe425 @phofl