-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: Enforce deprecation of using alias for builtin/NumPy funcs #57444
Conversation
# Conflicts: # doc/source/whatsnew/v3.0.0.rst
# Conflicts: # doc/source/whatsnew/v3.0.0.rst
A bit of a complication here - I missed one of the paths in apply where we use the builtin/NumPy -> cython table. Lines 1439 to 1442 in 54d2033
Sadly, it's probably one of the more common cases where users will see a difference. This is because I'm thinking we enforce the deprecation as-is (we already were not very consistent with where we were making these replacements), and deprecate the last remaining case as part of 3.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes generally look good. npdev failure looks real?
I'm thinking we enforce the deprecation as-is (we already were not very consistent with where we were making these replacements), and deprecate the last remaining case as part of 3.x.
Yeah fine to do a follow up deprecation in 3.x
# Conflicts: # doc/source/whatsnew/v3.0.0.rst
Yes, sounds good to me too! |
@mroeschke - green now. |
Thanks @rhshadrach |
…as-dev#57444) * CLN: Enforce deprecation of using alias for builtin/NumPy funcs * GH# and whatsnew * Fixup docs * More tests * Restore docstring * Test fixes * Test fixups * Test fixes * Test fixup * Test fixes - [ ] closes #xxxx (Replace xxxx with the GitHub issue number) - [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature - [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit). - [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions. - [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.
CLN: Enforce deprecation of using alias for builtin/NumPy funcs (pandas-dev#57444)
…as-dev#57444) * CLN: Enforce deprecation of using alias for builtin/NumPy funcs * GH# and whatsnew * Fixup docs * More tests * Restore docstring * Test fixes * Test fixups * Test fixes * Test fixup * Test fixes
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Ref: #53974