Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: ‘AS’, ‘BA’ and ‘BAS’ in favour of ‘YS’, ‘BY’ and ‘BYS’ #55479

Merged
merged 4 commits into from
Oct 11, 2023
Merged

DEPR: ‘AS’, ‘BA’ and ‘BAS’ in favour of ‘YS’, ‘BY’ and ‘BYS’ #55479

merged 4 commits into from
Oct 11, 2023

Conversation

natmokval
Copy link
Contributor

xref #55252

  • deprecated strings ‘AS’, ‘BA’ and ‘BAS’ in favour of ‘YS’, ‘BY’ and ‘BYS’.
  • 
deprecated annual frequencies with various fiscal business year ends: “BA-DEC", “BA-JAN", etc. in favour of “BY-DEC", “BY-JAN", etc.
  • deprecated annual frequencies with various fiscal year begin: “AS-DEC", “AS-JAN", etc. in favour of “YS-DEC", “YS-JAN", etc.

@natmokval natmokval marked this pull request as ready for review October 11, 2023 12:25
@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Oct 11, 2023
MarcoGorelli
MarcoGorelli approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think this is just missing a 2.2.0 whatsnew note?

OK to add it in the next PR though, happy to get this in before conflicts creep in 😄

@natmokval
Copy link
Contributor Author

Nice!

I think this is just missing a 2.2.0 whatsnew note?

OK to add it in the next PR though, happy to get this in before conflicts creep in 😄

yes, it would be great if we can get it in. I will add the note to 2.2.0 whatsnew in my next PR.

@MarcoGorelli MarcoGorelli added this to the 2.2 milestone Oct 11, 2023
@MarcoGorelli MarcoGorelli added the Frequency DateOffsets label Oct 11, 2023
@MarcoGorelli MarcoGorelli merged commit c9a98f0 into pandas-dev:main Oct 11, 2023
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Open
gupta-paras pushed a commit to gupta-paras/pandas that referenced this pull request Oct 12, 2023
@natmokval @gupta-paras
DEPR: ‘AS’, ‘BA’ and ‘BAS’ in favour of ‘YS’, ‘BY’ and ‘BYS’ (pandas-…
ee4a39a 
…dev#55479)

* deprecate AS/BA/BAS in favour of YS/BY/BYS, fix tests

* correct def get_start_end_field, correct docstrings and v0.20.0.rst

* fix pre-commit error

* add deprecated frequencies to dict DEPR_ABBREVS, add tests
@spencerkclark spencerkclark mentioned this pull request Nov 1, 2023
Closed
@jessegrabowski jessegrabowski mentioned this pull request Feb 14, 2024
Merged
@natmokval natmokval mentioned this pull request Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Frequency DateOffsets
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@natmokval @MarcoGorelli @mroeschke