Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API/DEPR: Rename DataFrame.applymap to DataFrame.map #52364
API/DEPR: Rename DataFrame.applymap to DataFrame.map #52364
Changes from 17 commits
1ef894f
6427c91
63d7663
08d4425
0cdbfc3
1e5b5c5
69f7c08
e1c30b8
8bad43b
7635550
603cb74
6ef09ae
164bae7
0294062
ce0f2f0
3994376
390ac79
c1d0b50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are changing
DataFrame.applymap()
toDataFrame.map()
, shouldn't we then changeStyler.applymap()
toStyler.map()
to make things consistent?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a logical next step and @attack68 has proposed in #52353 (comment) to takie on
styler.applymap
after this has been merged.A good idea IMO.