Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecate allowing slice in DataFrame.take #51539

Merged
merged 3 commits into from
Feb 22, 2023
Merged

DEPR: deprecate allowing slice in DataFrame.take #51539

merged 3 commits into from
Feb 22, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

mroeschke
mroeschke reviewed Feb 21, 2023
View reviewed changes
@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Feb 21, 2023
@jbrockmendel @mroeschke
Update pandas/core/generic.py
dd41074 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@phofl phofl added this to the 2.1 milestone Feb 22, 2023
@phofl phofl merged commit 3f3102b into pandas-dev:main Feb 22, 2023
@phofl
Copy link
Member

phofl commented Feb 22, 2023

thx @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-take branch February 22, 2023 00:57
@phofl phofl mentioned this pull request Feb 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @phofl @mroeschke