Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: silently ignoring unrecognized timezones #51477

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 18, 2023

WIP part is need to figure out #51476 before the deprecation warning will be issued by to_datetime.Update: addressed.

@simonjayhawkins simonjayhawkins added Timezones Timezone data dtype Deprecate Functionality to remove in pandas labels Feb 22, 2023
@jbrockmendel
Copy link
Member Author

updated to handle strptime inference cc @MarcoGorelli

@jbrockmendel jbrockmendel changed the title WIP/DEPR: silently ignoring unrecognized timezones DEPR: silently ignoring unrecognized timezones Feb 28, 2023
@MarcoGorelli MarcoGorelli self-requested a review February 28, 2023 13:50
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea just to raise the warning on the pandas side, so that we have control over it and can raise in the future?

Looks good to me!

@MarcoGorelli
Copy link
Member

WIP part is need to figure out #51476 before the deprecation warning will be issued by to_datetime.

Looks like you've figured this out? guess_datetime_format now raises the deprecation warning

@jbrockmendel
Copy link
Member Author

Is the idea just to raise the warning on the pandas side, so that we have control over it and can raise in the future?

yes.

Looks like you've figured this out? guess_datetime_format now raises the deprecation warning

yes.

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Feb 28, 2023
@MarcoGorelli MarcoGorelli merged commit 3b632d9 into pandas-dev:main Feb 28, 2023
@jbrockmendel jbrockmendel deleted the depr-silent-tz-dropping branch February 28, 2023 17:41
@phofl
Copy link
Member

phofl commented Feb 28, 2023

note was added for 2.0, do we want to backport or move the note?

@jbrockmendel
Copy link
Member Author

probably better to move the note. will add to my next Assorted branch

@phofl
Copy link
Member

phofl commented Feb 28, 2023

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: inferring incorrect datetime format Timezones silently dropped in parsing
4 participants