Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: ADD FutureWarning for pandas.io.execute #50676

Merged

Conversation

luke396
Copy link
Contributor

@luke396 luke396 commented Jan 11, 2023

reopen for DEPR: Add FutureWarning for pandas.io.sql.execute Pull Request #50638

@luke396
Copy link
Contributor Author

luke396 commented Jan 11, 2023

@phofl, sorry again, we can start over here!

I'm not sure if it's appropriate and polite for me to start a new PR directly, if not, please let me know directly
!

@phofl phofl changed the title DEPR: ADD FutureWarning for pandas.io.excute DEPR: ADD FutureWarning for pandas.io.execute Jan 11, 2023
@phofl
Copy link
Member

phofl commented Jan 11, 2023

It's fine :) Thanks for continuing, looks good generally, we are holding off on merging deprecations, so will merge when we are ready with our old deprecations

@luke396
Copy link
Contributor Author

luke396 commented Jan 12, 2023

I apologize if my change has caused the check failure below again. Could you kindly inform me if it is related, and guide me on how to resolve it? If my change is not related, there is no need to respond. I greatly appreciate your help with this matter.

@phofl phofl added IO SQL to_sql, read_sql, read_sql_query Deprecate Functionality to remove in pandas labels Jan 12, 2023
@phofl phofl added this to the 2.0 milestone Jan 12, 2023
@phofl phofl merged commit d67fad5 into pandas-dev:main Jan 12, 2023
@phofl
Copy link
Member

phofl commented Jan 12, 2023

thx @luke396 failures were unrelated

@luke396
Copy link
Contributor Author

luke396 commented Jan 12, 2023

thx @luke396 failures were unrelated

I've noticed that you all are working hard to fix the CI issues. Keep up the good work! 😄

@luke396 luke396 deleted the add-FutureWarning-for-pandas.io.sql.execute_new branch January 12, 2023 16:15
@@ -556,9 +556,10 @@ Other API changes
Deprecations
~~~~~~~~~~~~
- Deprecated argument ``infer_datetime_format`` in :func:`to_datetime` and :func:`read_csv`, as a strict version of it is now the default (:issue:`48621`)
- Deprecated :func:`pandas.io.sql.execute`(:issue:`50185`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think may need a space to render properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: pandas.io.sql.execute
3 participants