ENH/TST: Add BaseMethodsTests tests for ArrowExtensionArray #47552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Jun 30, 2022
•
mroeschke
commented
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
mroeschke
added
Testing
jreback
approved these changes
Jul 3, 2022
|
Will take a look today (and start whittling down the ping backlog) |
jbrockmendel
reviewed
Jul 5, 2022
| @@ -49,8 +50,7 @@ def test_value_counts_with_normalize(self, data): | |||
| else: | |||
| expected = pd.Series(0.0, index=result.index) | |||
| expected[result > 0] = 1 / len(values) | |||
|
|
|||
| if isinstance(data.dtype, pd.core.dtypes.dtypes.BaseMaskedDtype): | |||
| if na_value_for_dtype(data.dtype) is pd.NA: | |||
There was a problem hiding this comment.
not for this PR, but we probably need to find a way to let authors define na_value_for_dtype
There was a problem hiding this comment.
Probably similar to #27825
jbrockmendel
reviewed
Jul 5, 2022
| super().test_container_shift(data, frame, periods, indices) | ||
|
|
||
| @pytest.mark.xfail( | ||
| reason="result dtype pyarrow[bool] better than expected dtype object" |
There was a problem hiding this comment.
medium-term should just override the test with the correct/better behavior
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…ev#47552) * ENH/TST: Add BaseMethodsTests tests for ArrowExtensionArray * Passing test now * add xfails for arraymanager * Fix typo * Trigger CI * Add xfails for min version and datamanger * Adjust more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.