test docker deploy with BUILDPLATFORM

pabra · Jun 13, 2024 · 84aa69e · 84aa69e
1 parent 52e5886
commit 84aa69e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -64,8 +64,8 @@ jobs:
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
-        # with:
-        #   platforms: linux/amd64,linux/arm64,linux/arm/v7
+        with:
+          platforms: linux/amd64,linux/arm64,linux/arm/v7
 
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3

diff --git a/Dockerfile b/Dockerfile
@@ -1,7 +1,10 @@
 # use node:lts-alpine
+# build hangs for arm/v7 platform on alpine image
+# https://github.com/nodejs/docker-node/issues/2077
+# let's use slim for now
 ARG BASE_IMAGE=node:20.14.0-alpine
 
-FROM ${BASE_IMAGE} AS builder
+FROM --platform=$BUILDPLATFORM ${BASE_IMAGE} AS builder
 
 WORKDIR /app
 
@@ -24,7 +27,7 @@ COPY src src/
 RUN npm run test:before-publish
 
 
-FROM ${BASE_IMAGE}
+FROM --platform=$BUILDPLATFORM ${BASE_IMAGE}
 
 WORKDIR /app