Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed/namespace tofino #5218

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Fixed/namespace tofino #5218

wants to merge 18 commits into from

Conversation

AkarshSahlot
Copy link
Contributor

Changes: I wrapped all bfn with p4 like the files which were in form bfn{ ,are now in form of P4{ bfn {.

the files which were lacking namespaces I added them , this was in alloc file ,
Some files are attached below to description that species that no llm was used or taken help with,
IMG_0815 2
as a
Proof of work.
the files bfn which are wrapped with p4 are :-
backends/tofino/bf-p4c/mau/dynhash.cpp
backends/tofino/bf-p4c/mau/dynhash.h
backends/tofino/bf-p4c/mau/input_xbar.h
backends/tofino/bf-p4c/mau/ixbar_info.h
backends/tofino/bf-p4c/mau/adjust_byte_count.cpp
backends/tofino/bf-p4c/mau/ixbar_info.cpp
backends/tofino/bf-p4c/mau/adjust_byte_count.h
backends/tofino/bf-p4c/backend.h
backends/tofino/bf-p4c/backend.cpp
backends/tofino/bf-p4c/ir/ir_enums.h
backends/tofino/bf-p4c/ir/control_flow_visitor.h
backends/tofino/bf-p4c/ir/ir_enums.cpp
backends/tofino/bf-p4c/ir/control_flow_visitor.cpp
backends/tofino/bf-p4c/ir/gateway_control_flow.h
backends/tofino/bf-p4c/arch/tna.h
backends/tofino/bf-p4c/arch/program_structure.h
backends/tofino/bf-p4c/arch/intrinsic_metadata.h
backends/tofino/bf-p4c/arch/psa/psa_model.h
backends/tofino/bf-p4c/arch/psa/psa_converters.cpp
backends/tofino/bf-p4c/arch/psa/psa.cpp
backends/tofino/bf-p4c/arch/psa/programStructure.cpp
backends/tofino/bf-p4c/arch/psa/programStructure.h
backends/tofino/bf-p4c/arch/psa/psa_converters.h
backends/tofino/bf-p4c/arch/psa/rewrite_packet_path.h
backends/tofino/bf-p4c/arch/psa/rewrite_bridge_metadata.h
backends/tofino/bf-p4c/arch/psa/psa_model.cpp
backends/tofino/bf-p4c/arch/psa/rewrite_packet_path.cpp
backends/tofino/bf-p4c/arch/psa/psa.h
backends/tofino/bf-p4c/arch/psa/rewrite_bridge_metadata.cpp
backends/tofino/bf-p4c/arch/t2na.cpp
backends/tofino/bf-p4c/arch/program_structure.cpp
backends/tofino/bf-p4c/arch/arch.cpp
backends/tofino/bf-p4c/arch/remove_set_metadata.cpp
backends/tofino/bf-p4c/arch/rewrite_action_selector.h
backends/tofino/bf-p4c/arch/add_t2na_meta.cpp
backends/tofino/bf-p4c/arch/rewrite_action_selector.cpp
backends/tofino/bf-p4c/arch/v1model.cpp
backends/tofino/bf-p4c/arch/add_t2na_meta.h
backends/tofino/bf-p4c/arch/bridge_metadata.cpp
backends/tofino/bf-p4c/arch/fromv1.0/checksum.h
backends/tofino/bf-p4c/arch/fromv1.0/add_metadata_parser_states.cpp
backends/tofino/bf-p4c/arch/fromv1.0/resubmit.cpp
backends/tofino/bf-p4c/arch/fromv1.0/v1_converters.h
backends/tofino/bf-p4c/arch/fromv1.0/phase0.cpp
backends/tofino/bf-p4c/arch/fromv1.0/parser_counter.cpp
backends/tofino/bf-p4c/arch/fromv1.0/checksum.cpp
backends/tofino/bf-p4c/arch/fromv1.0/mirror.cpp
backends/tofino/bf-p4c/arch/fromv1.0/add_metadata_parser_states.h
backends/tofino/bf-p4c/arch/fromv1.0/v1_converters.cpp
backends/tofino/bf-p4c/arch/fromv1.0/v1_program_structure.cpp
backends/tofino/bf-p4c/arch/fromv1.0/v1_program_structure.h
backends/tofino/bf-p4c/arch/fromv1.0/phase0.h
backends/tofino/bf-p4c/arch/fromv1.0/resubmit.h
backends/tofino/bf-p4c/arch/fromv1.0/parser_counter.h
backends/tofino/bf-p4c/arch/fromv1.0/mirror.h
backends/tofino/bf-p4c/arch/arch.h
backends/tofino/bf-p4c/arch/collect_hardware_constrained_fields.h
backends/tofino/bf-p4c/arch/helpers.h
backends/tofino/bf-p4c/arch/intrinsic_metadata.cpp
backends/tofino/bf-p4c/arch/helpers.cpp
backends/tofino/bf-p4c/arch/v1model.h
backends/tofino/bf-p4c/arch/remove_set_metadata.h
backends/tofino/bf-p4c/arch/collect_bridged_fields.cpp
backends/tofino/bf-p4c/arch/check_extern_invocation.h
backends/tofino/bf-p4c/arch/check_extern_invocation.cpp
backends/tofino/bf-p4c/arch/collect_hardware_constrained_fields.cpp
backends/tofino/bf-p4c/arch/tna.cpp
backends/tofino/bf-p4c/arch/t2na.h
backends/tofino/bf-p4c/arch/collect_bridged_fields.h
backends/tofino/bf-p4c/arch/bridge_metadata.h
backends/tofino/bf-p4c/test/gtest/field_packing.cpp
backends/tofino/bf-p4c/test/gtest/path_linearizer.cpp
backends/tofino/bf-p4c/test/gtest/type_categories.cpp
backends/tofino/bf-p4c/test/gtest/tofino_gtest_utils.h
backends/tofino/bf-p4c/test/gtest/bf_gtest_helpers.h
backends/tofino/bf-p4c/control-plane/p4runtime_force_std.cpp
backends/tofino/bf-p4c/control-plane/bfruntime_arch_handler.h
backends/tofino/bf-p4c/control-plane/bfruntime_ext.cpp
backends/tofino/bf-p4c/control-plane/bfruntime.cpp
backends/tofino/bf-p4c/control-plane/p4runtime_force_std.h
backends/tofino/bf-p4c/control-plane/bfruntime.h
backends/tofino/bf-p4c/control-plane/runtime.h
backends/tofino/bf-p4c/control-plane/runtime.cpp
backends/tofino/bf-p4c/control-plane/bfruntime_ext.h
backends/tofino/bf-p4c/midend.cpp
backends/tofino/bf-p4c/asm.cpp
backends/tofino/bf-p4c/logging/resources_parser.cpp
backends/tofino/bf-p4c/logging/collect_diagnostic_checks.cpp
backends/tofino/bf-p4c/logging/resources.h
backends/tofino/bf-p4c/logging/resources.cpp
backends/tofino/bf-p4c/logging/resources_clot.h
backends/tofino/bf-p4c/logging/collect_diagnostic_checks.h
backends/tofino/bf-p4c/logging/resources_parser.h
backends/tofino/bf-p4c/logging/resources_clot.cpp
backends/tofino/bf-p4c/midend.h
backends/tofino/bf-p4c/p4c-barefoot.cpp
backends/tofino/bf-p4c/common/alloc.h
backends/tofino/bf-p4c/common/extract_maupipe.cpp
backends/tofino/bf-p4c/common/parse_annotations.h
backends/tofino/bf-p4c/common/extract_maupipe.h
backends/tofino/bf-p4c/common/debug_info.h
backends/tofino/bf-p4c/common/size_of.cpp
backends/tofino/bf-p4c/common/merge_pov_bits.cpp
backends/tofino/bf-p4c/common/merge_pov_bits.h
backends/tofino/bf-p4c/common/pragma.h
backends/tofino/bf-p4c/common/pragma/pragma.h
backends/tofino/bf-p4c/common/front_end_policy.h
backends/tofino/bf-p4c/common/size_of.h
backends/tofino/bf-p4c/common/header_stack.h
backends/tofino/bf-p4c/asm.h
backends/tofino/bf-p4c/lib/error_type.h
backends/tofino/bf-p4c/parde/field_packing.cpp
backends/tofino/bf-p4c/parde/extract_deparser.cpp
backends/tofino/bf-p4c/parde/extract_parser.h
backends/tofino/bf-p4c/parde/parser_info.h
backends/tofino/bf-p4c/parde/extract_deparser.h
backends/tofino/bf-p4c/parde/deparser_checksum_update.cpp
backends/tofino/bf-p4c/parde/deparser_checksum_update.h
backends/tofino/bf-p4c/parde/extract_parser.cpp
backends/tofino/bf-p4c/parde/clot/clot.h
backends/tofino/bf-p4c/parde/parser_loops_info.cpp
backends/tofino/bf-p4c/parde/field_packing.h
backends/tofino/bf-p4c/parde/parser_loops_info.h
backends/tofino/bf-p4c/midend/fold_constant_hashes.cpp
backends/tofino/bf-p4c/midend/check_register_actions.cpp
backends/tofino/bf-p4c/midend/elim_cast.cpp
backends/tofino/bf-p4c/midend/rewrite_egress_intrinsic_metadata_header.h
backends/tofino/bf-p4c/midend/check_register_actions.h
backends/tofino/bf-p4c/midend/copy_header.h
backends/tofino/bf-p4c/midend/collect_pipelines.h
backends/tofino/bf-p4c/midend/type_categories.h
backends/tofino/bf-p4c/midend/path_linearizer.cpp
backends/tofino/bf-p4c/midend/ping_pong_generation.h
backends/tofino/bf-p4c/midend/check_unsupported.h
backends/tofino/bf-p4c/midend/type_checker.cpp
backends/tofino/bf-p4c/midend/check_design_pattern.h
backends/tofino/bf-p4c/midend/alpm.h
backends/tofino/bf-p4c/midend/simplify_args.cpp
backends/tofino/bf-p4c/midend/parser_enforce_depth_req.h
backends/tofino/bf-p4c/midend/alpm.cpp
backends/tofino/bf-p4c/midend/detect_multiple_pipelines.cpp
backends/tofino/bf-p4c/midend/eliminate_tuples.h
backends/tofino/bf-p4c/midend/initialize_mirror_io_select.cpp
backends/tofino/bf-p4c/midend/remove_select_booleans.h
backends/tofino/bf-p4c/midend/path_linearizer.h
backends/tofino/bf-p4c/midend/type_categories.cpp
backends/tofino/bf-p4c/midend/detect_multiple_pipelines.h
backends/tofino/bf-p4c/midend/simplify_args.h
backends/tofino/bf-p4c/midend/type_checker.h
backends/tofino/bf-p4c/midend/collect_pipelines.cpp
backends/tofino/bf-p4c/midend/annotate_with_in_hash.h
backends/tofino/bf-p4c/midend/drop_packet_with_mirror_engine.h
backends/tofino/bf-p4c/midend/desugar_varbit_extract.h
backends/tofino/bf-p4c/midend/initialize_mirror_io_select.h
backends/tofino/bf-p4c/midend/eliminate_tuples.cpp
backends/tofino/bf-p4c/midend/register_read_write.cpp
backends/tofino/bf-p4c/midend/register_read_write.h
backends/tofino/bf-p4c/midend/simplify_key_policy.h
backends/tofino/bf-p4c/midend/check_header_alignment.h
backends/tofino/bf-p4c/midend/remove_action_params.h
backends/tofino/bf-p4c/midend/action_synthesis_policy.h
backends/tofino/bf-p4c/midend/fold_constant_hashes.h
backends/tofino/bf-p4c/midend/check_unsupported.cpp
backends/tofino/bf-p4c/midend/elim_cast.h
backends/tofino/bf-p4c/midend/parser_enforce_depth_req.cpp
backends/tofino/bf-p4c/midend/desugar_varbit_extract.cpp
backends/tofino/bf-p4c/midend/check_header_alignment.cpp
backends/tofino/bf-p4c/midend/annotate_with_in_hash.cpp
backends/tofino/bf-p4c/midend/rewrite_flexible_header.h
backends/tofino/bf-p4c/midend/ping_pong_generation.cpp
backends/tofino/bf-p4c/midend/drop_packet_with_mirror_engine.cpp
backends/tofino/bf-asm/alloc.h
Pls review and tell me what changes more to din it
IMG_0812 2

IMG_0813 2

IMG_0814 2
fixes #5217

AkarshSahlot and others added 16 commits March 31, 2025 20:32
@AkarshSahlot
Skip PSATernaryTest on Ubuntu 22.04 and add Black formatting
245c827 
Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@AkarshSahlot
Formatted code with black and fixed indentation
6d72084 
Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@fruffy @AkarshSahlot
Correctly attach the dontmerge annotation in the desugar_varbit_extra…
c460133 
…ct pass. (p4lang#5193)

Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@AkarshSahlot
xUpdate test.py
5cd4ae8 
removed Commented section

Signed-off-by: Akarsh Sahlot <122122123+AkarshSahlot@users.noreply.github.com>
Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@AkarshSahlot
reformat it with black and resolved ebpf by adding the missing import…
76ebc49 
… unittest

Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@jafingerhut @AkarshSahlot
Update ptf-ebpf CI test to Ubuntu 22.04 (p4lang#5159)
399b1d3 
Signed-off-by: Andy Fingerhut <andy.fingerhut@gmail.com>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
@AkarshSahlot
Merge branch 'main' into fix-psa-ternary-test
10b9895 
Signed-off-by: Akarsh Sahlot <122122123+AkarshSahlot@users.noreply.github.com>
@AkarshSahlot
Temporary commit before pulling latest changes
98c054a
@AkarshSahlot
fixed reformatting using cmake build
745a106 
Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@AkarshSahlot
style: Fix import order in test.py per isort
6ef3643
@AkarshSahlot
style: Fix import order in test.py isort and also add new skip decorator
d1bb7fd 
Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@AkarshSahlot
DCO Remediation Commit for Akarsh Sahlot <akarshsahlot7@gmail.com>
1b0ae94 
I, Akarsh Sahlot <akarshsahlot7@gmail.com>, hereby add my Signed-off-by to this commit: 98c054a
I, Akarsh Sahlot <akarshsahlot7@gmail.com>, hereby add my Signed-off-by to this commit: 6ef3643

Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@AkarshSahlot
revert back files, fixed code
5f6739f 
Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@AkarshSahlot
Update namespaces in Tofino backend files (Issue p4lang#5214)
3010c21
@AkarshSahlot
fixes namespace in tofino
864c095 
Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@AkarshSahlot
fixed syntax
204f919 
Signed-off-by: Akarsh Sahlot <akarshsahlot7@gmail.com>
@fruffy
Copy link
Collaborator

fruffy commented Apr 3, 2025

Pls review and tell me what changes more to din it

It makes sense to review this PR once the test-p4c-debian / test-ubuntu22-tofino test is passing.

@AkarshSahlot
Copy link
Contributor Author

Pls review and tell me what changes more to din it

It makes sense to review this PR once the test-p4c-debian / test-ubuntu22-tofino test is passing.

ok I will look upon it

@AkarshSahlot
Merge branch 'main' into fixed/namespace-tofino
61294de
@AkarshSahlot
Delete backends/ebpf/tests/ptf/test.py
e02564b 
unnnecessary push

Signed-off-by: Akarsh Sahlot <122122123+AkarshSahlot@users.noreply.github.com>
@fruffy fruffy added the tofino Topics related to the Tofino switch and back end. label Apr 4, 2025
@fruffy fruffy requested a review from Copilot April 5, 2025 10:16
Copilot
Copilot AI reviewed Apr 5, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 149 out of 169 changed files in this pull request and generated no comments.

Files not reviewed (20)
  • backends/tofino/bf-asm/alloc.h: Language not supported
  • backends/tofino/bf-p4c/arch/add_t2na_meta.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/add_t2na_meta.h: Language not supported
  • backends/tofino/bf-p4c/arch/arch.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/arch.h: Language not supported
  • backends/tofino/bf-p4c/arch/bridge_metadata.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/bridge_metadata.h: Language not supported
  • backends/tofino/bf-p4c/arch/check_extern_invocation.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/check_extern_invocation.h: Language not supported
  • backends/tofino/bf-p4c/arch/collect_bridged_fields.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/collect_bridged_fields.h: Language not supported
  • backends/tofino/bf-p4c/arch/collect_hardware_constrained_fields.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/collect_hardware_constrained_fields.h: Language not supported
  • backends/tofino/bf-p4c/arch/fromv1.0/add_metadata_parser_states.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/fromv1.0/add_metadata_parser_states.h: Language not supported
  • backends/tofino/bf-p4c/arch/fromv1.0/checksum.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/fromv1.0/mirror.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/fromv1.0/mirror.h: Language not supported
  • backends/tofino/bf-p4c/arch/fromv1.0/parser_counter.cpp: Language not supported
  • backends/tofino/bf-p4c/arch/fromv1.0/parser_counter.h: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
tofino Topics related to the Tofino switch and back end.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkarshSahlot @fruffy @jafingerhut