Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confidential & proprietary notices from Tofino testgen test programs #5189

Conversation

jafingerhut
Copy link
Contributor

@jafingerhut jafingerhut commented Mar 23, 2025

All of these files had an Intel copyright notice and Apache-2.0 license earlier in the file's text than the older confidential & proprietary notices that are being removed in this change. It appears that some automated process was used to add the new copyright notices before publication, but they failed to remove the old one.

With these changes, every one of the changed files still has a copyright notes and an Apache-2.0 license notice, which I am not adding, but leaving there unchanged.

…ograms

All of these files had an Intel copyright notice and Apache-2.0
license _before_ the older confidential & proprietary notices that are
being removed in this change.  It appears that some automated process
was used to add the new copyright notices before publication, but they
failed to remove the old one.

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
@jafingerhut jafingerhut requested review from fruffy and pkotikal March 23, 2025 14:49
@jafingerhut
Copy link
Contributor Author

@pkotikal It would be very good to have an Intel employee approve this PR, if it is acceptable to Intel, since the files are marked as copyright by Intel.

@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Mar 23, 2025
@vlstill vlstill requested a review from hanw March 25, 2025 13:30
@jafingerhut
Copy link
Contributor Author

@psivanup Pinging you, in case you are able to review and approve this, in your capacity as someone from Intel, which owns the copyright on these files.

@psivanup
Copy link
Contributor

psivanup commented Apr 3, 2025

@jafingerhut , I'll get back as soon as I get feedback from my team.

Copy link

@syogender syogender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jafingerhut jafingerhut added this pull request to the merge queue Apr 7, 2025
Merged via the queue into p4lang:main with commit 3f375c5 Apr 7, 2025
23 checks passed
@jafingerhut jafingerhut deleted the remove-confidential-notices-from-tofino-testgen-test-programs branch April 7, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants