Use bpftool instead of iproute2 to load eBPF and XDP maps. #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
ebpf
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
This reverts commit 46fde69. Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
|
@vbnogueira Might be interesting to you, although I do not think the p4tc back end will be much affected by these changes. |
|
@jafingerhut Unlikely to find any stakeholders with approval rights on this PR so I am asking for a review from you :). |
jafingerhut
reviewed
Mar 26, 2025
| @@ -145,6 +154,44 @@ def _attach_filters(self, bridge, proc): | |||
| return result | |||
| return testutils.SUCCESS | |||
|
|
|||
| # def _attach_filters(self, bridge: Bridge, proc: subprocess.Popen) -> int: | |||
There was a problem hiding this comment.
Do you think this commented-out function is likely to be useful in the future?
There was a problem hiding this comment.
Ah, looks like this is the wrong branch... making this draft again. Losing track of all the PRs. Apologize for the premature ping!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2407
Makes loading eBPF programs a little bit less dependent on the distribution.