Cleaned PNA_NIC PSA_SWITCH code #5078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the p4c-lint CI test found some code formatting issues that can be fixed using clang-format. Let us know if you need help looking at the log, or figuring out how to run clang-format on the necessary files. |
rupesh-chiluka-marvell
force-pushed
the
p4c_clean_code
branch
from
b079f1d to
f4c3bf2
Compare
fruffy
reviewed
Dec 30, 2024
backends/bmv2/pna_nic/main.cpp
Outdated
| @@ -36,6 +33,9 @@ limitations under the License. | |||
| #include "lib/gc.h" | |||
| #include "lib/log.h" | |||
| #include "lib/nullstream.h" | |||
| #include "midend.h" | |||
There was a problem hiding this comment.
The other code doesn't follow this style. Any reason why you want to remove the prefix?
There was a problem hiding this comment.
Sorry. I misunderstood.
In the .cpp file, only the include statement of its own .h file has no prefix.
Signed-off-by: Rupesh Chiluka <rchiluka@marvell.com>
rupesh-chiluka-marvell
force-pushed
the
p4c_clean_code
branch
from
f4c3bf2 to
aaa797c
Compare
fruffy
approved these changes
Mar 19, 2025
fruffy
reviewed
Mar 19, 2025
| auto bitwidth = param->type->width_bits(); | ||
| jsn->emplace("name", param->toString()); | ||
| jsn->emplace("type", "hexstr"); | ||
| auto bitwidth = 0; |
There was a problem hiding this comment.
@rupesh-chiluka-marvell Why 0 here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted few headers.
Removed the "_cs" in pna_nic, which are modified in the psa_switch code long back.
Removed comments.