fixes #589 allow min and max to be within range #733
Conversation
|
Hey @ahl does this fix look ok to you? |
typify-impl/src/convert.rs
Outdated
| && (min.map(|f| f.ge(imin)).unwrap_or(false)) | ||
| && (max.map(|f| f.le(imax)).unwrap_or(false)) |
There was a problem hiding this comment.
this doesn't seem quite right. Previously the logic said: "if it's None OR is the specified bound". Now this says "if it's Some AND is within the specified bound". So this will only apply if both the minimum and maximum values are set in the schema.
I'm not sure of the best path forward here. I tried adjusting this, but then the NonZeroUXX tests failed. One option might be to specify add formats for the NonZeroXX types in the table above and then here to filter rather than find.
|
Thanks, I will take a look through them |
|
@ahl not quite there, I feel like we need to change the way that the NonZero types are applied because I presume we still want to use them when a format has been specified but that pattern doesn't fit with the Can I just confirm that we want |
Yes. I'm less certain about other schemas. That is to say: I'm not sure that |
|
OK, thanks, I will stick to just applying it to minimum 1. Should be able to look at this at the weekend. |
fixes #589
Allow min and max to be within range of the specified format