Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] TUF integration in Nexus + update artifact fetching by sled-agent #717
[v2] TUF integration in Nexus + update artifact fetching by sled-agent #717
Changes from 48 commits
fc70559
80250e1
3ac2ddb
9357831
67fa74c
d7728a1
7900929
a3f8121
fad83b5
4523cbd
e82885c
dc5897a
3e82573
55de464
9eab4b8
383d966
76a6bf9
8ad7ad6
aec3211
9426256
f65f1bb
c653a11
e68080f
3f42295
0618d09
62e54d0
e2af470
3c6bd7d
1afe334
405d1f8
52b5c29
7766021
e22c736
9116b07
a5c357b
ec1f4d4
374ffc7
a4866fd
391d7f2
57238b0
832cb95
a1cb33f
5a62f58
7d49637
b483cf0
449d24a
eae1452
6f5264d
1b489dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it seems straightforward to me that we'll host a TUF repo somewhere, and set the value according to that (for
default_base_url
) but where would theroot.json
file come from?I saw you added it to the
.gitignore
, but if we merge this PR and I want to actually set up a TUF repo + go through this workflow, where should I get this file from?(If this is a step a developer must do manually, maybe we should add some docs?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I expect we'll add during CI. We might have a different root.json for test builds, for instance. (A generic root.json might work here, but how do you share that key, and how do you avoid shipping production builds with that role as the trusted root?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this seems like a decent tradeoff to not break folks doing development.