dev: Make db-run check CockroachDB version #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help catch when developers forget to upgrade their version
to match the one in use by the repo.
Example failure:
$ cargo run --bin omicron-dev db-run
Compiling omicron-test-utils v0.1.0
Finished dev [unoptimized + debuginfo] target(s) in 5.94s
Running `target/debug/omicron-dev db-run`
omicron-dev: using temporary directory for database store (cleaned up on clean exit)
omicron-dev: will run this to start CockroachDB:
cockroach start-single-node --insecure --http-addr=:0 [...]
omicron-dev: temporary directory: /tmp/.tmpWJTKQn
omicron-dev: wrong version of CockroachDB installed. expected 'v21.1.11', found: 'Ok("v21.1.10")
| @@ -14,7 +14,7 @@ SOURCE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" | |||
| ARG0="$(basename ${BASH_SOURCE[0]})" | |||
|
|
|||
| # If you change this, you must also update the md5sums below | |||
| CIDL_VERSION="v21.1.10" | |||
| CIDL_VERSION="$(cat "$SOURCE_DIR/cockroachdb_version")" | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
It did :) I think I raced catching that and uploading the file with you seeing the patch
david-crespo
approved these changes
Nov 24, 2021
|
Looks like this is failing in docker builds (on the include_str invocation). I'll try to sort out what's up there |
|
Oh, okay, that was from the first commit. |
|
I hate those run failure emails 😁 |
teisenbe
added a commit
that referenced
this pull request
Dec 2, 2021
This reverts commit 9a830b4. The commit broke running under Helios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help catch when developers forget to upgrade their version
to match the one in use by the repo.
Example failure:
$ cargo run --bin omicron-dev db-run
Compiling omicron-test-utils v0.1.0
Finished dev [unoptimized + debuginfo] target(s) in 5.94s
Running
target/debug/omicron-dev db-runomicron-dev: using temporary directory for database store (cleaned up on clean exit)
omicron-dev: will run this to start CockroachDB:
cockroach start-single-node --insecure --http-addr=:0 [...]
omicron-dev: temporary directory: /tmp/.tmpWJTKQn
omicron-dev: wrong version of CockroachDB installed. expected 'v21.1.11', found: 'Ok("v21.1.10")