Merge version and version_sort
#2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
force-pushed
the
sortable-version
branch
from
4404d63 to
6117a8a
Compare
david-crespo
force-pushed
the
sortable-version
branch
from
c46f007 to
190d707
Compare
|
Cool, yeah. I much prefer only having one column representing the version. |
zephraph
reviewed
Feb 10, 2023
| version STRING(64) NOT NULL, -- TODO: length | ||
| -- version string with maj/min/patch 0-padded to be string sortable | ||
| version_sort STRING(64) NOT NULL -- TODO: length | ||
| version STRING(64) NOT NULL -- TODO: length |
There was a problem hiding this comment.
One random thing here... I noticed a lot of other strings are defined as 63 characters in the DB and I'm not exactly sure why that is.
There was a problem hiding this comment.
It seems like CRDB itself imposes that length limit on some of its internal strings: https://www.cockroachlabs.com/docs/stable/schema-design-overview.html#hard-limits
There was a problem hiding this comment.
Oh yeah, there's a comment at the top but it is ambivalent about 63 or 64.
omicron/common/src/sql/dbinit.sql
Lines 11 to 16 in 302a730
zephraph
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2344. Followup to #2100. Rather than manually adding a sortable
version_sortcolumn alongside theversioncolumn, makeSemverVersionitself automatically sortable by serializing it to the DB in sortable form (with zero padding on the numbers). On deserialization, we remove the padding before trying to parse it.