Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally include additional header values in request log #1060

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jclulow
Copy link
Collaborator

@jclulow jclulow commented Jul 12, 2024

I would like to be able to log additional headers in some applications, like X-Forwarded-For, which is potentially critical for programs that sit behind a reverse proxy. This change allows the consumer to list additional headers for inclusion in request log records.

@davepacheco
Copy link
Collaborator

I'm finding myself wishing we had a better solution for the more general thing here (i.e., allowing consumers to record whatever information they would find useful at various points in the server and request lifecycle). In the meantime, this seems reasonable. I was a little worried about the new dynamic-keys slog feature but it looks like Omicron already enables that.

@davepacheco davepacheco merged commit 7b594d0 into main Jul 16, 2024
11 checks passed
@davepacheco davepacheco deleted the x-forwarded-for branch July 16, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants