Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): use is_lexical when checking for lexical decl #9781

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Mar 14, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review March 14, 2025 09:39
Copy link
Contributor Author

camc314 commented Mar 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 14, 2025
Copy link

codspeed-hq bot commented Mar 14, 2025

CodSpeed Performance Report

Merging #9781 will not alter performance

Comparing c/03-14-refactor_linter_use_is_lexical_when_checking_for_lexical_decl (05fe2cd) with main (f8628bc)

Summary

✅ 33 untouched benchmarks

@camc314 camc314 force-pushed the c/03-14-refactor_linter_use_is_lexical_when_checking_for_lexical_decl branch from 796751e to 43ee6a3 Compare March 14, 2025 09:49
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 14, 2025
Copy link
Member

Boshen commented Mar 14, 2025

Merge activity

  • Mar 14, 6:26 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 14, 6:26 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 14, 6:31 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the c/03-14-refactor_linter_use_is_lexical_when_checking_for_lexical_decl branch from 43ee6a3 to 05fe2cd Compare March 14, 2025 10:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 14, 2025
@graphite-app graphite-app bot merged commit 05fe2cd into main Mar 14, 2025
25 checks passed
@graphite-app graphite-app bot deleted the c/03-14-refactor_linter_use_is_lexical_when_checking_for_lexical_decl branch March 14, 2025 10:31
Boshen added a commit that referenced this pull request Mar 16, 2025
## [0.16.0] - 2025-03-16

- 225e266 linter: [**BREAKING**] Enable `--experimental-nested-config`
by default and add `--disable-nested-config` option (#9760) (camchenry)

### Features

- 27d6e9b editor: Only watch .oxlintrc.json or user supplied config
paths (#9731) (Nicholas Rayburn)
- 8dd6809 linter: Add `eslint/no-lonely-if` (#9660) (therewillbecode)
- c22276e oxc_linter: Sort rules by plugin and rule name when outputting
resolved config as a JSON string (#9799) (Nicholas Rayburn)

### Bug Fixes

- 22f18ac linter: Improve `jsx-a11y/anchor-ambiguous-text` diagnostic
message (#9789) (1zumii)
- 6c11740 linter: False positive in `unicorn/catch-error-name` (#9763)
(shulaoda)

### Documentation

- ea6b6d9 linter: Improve docs for `eslint-valid-typeof` (#9797)
(therewillbecode)
- 2c48fba linter: Fix typo in `oxc/bad-min-max-func` (#9791) (Flo)
- 210b876 linter: Improve `eslint-no-async-promise-executor` (#9778)
(therewillbecode)
- f8628bc linter: Improve `eslint-no-class-assign` (#9779)
(therewillbecode)
- faca7a8 linter: Improve `eslint-no-self-assign` (#9768)
(therewillbecode)

### Refactor

- 227d203 linter: Improve `typescript-no-unnecessary-type-constraint`
(#9798) (therewillbecode)
- 05fe2cd linter: Use `is_lexical` when checking for lexical decl
(#9781) (camc314)
- fcdd810 linter: Remove if let nesting from `unicorn-no-date-clone`
(#9767) (therewillbecode)
- 5a9e1b9 linter: Improve `typescript-no-misused-new` (#9766)
(therewillbecode)
- 9df5565 linter: Improve `unicorn/filename-case` (#9762) (shulaoda)
- b0b1f18 linter: Remove if let nesting from
`nextjs-no-async-client-component` (#9764) (therewillbecode)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants