Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): Remove if let nesting from eslint-operator-assignment #9721

Merged

Conversation

therewillbecode
Copy link
Contributor

This PR just removes some if lets and uses let .. else instead for less levels of nesting.

Copy link

graphite-app bot commented Mar 12, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 12, 2025
Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #9721 will not alter performance

Comparing therewillbecode:refactor/eslint-operator-assignment (ac75107) with main (6c0978b)

Summary

✅ 33 untouched benchmarks

@Boshen Boshen merged commit 90b0227 into oxc-project:main Mar 12, 2025
25 checks passed
Boshen added a commit that referenced this pull request Mar 12, 2025
## [0.15.15] - 2025-03-12

### Features

- 2ddad59 linter: Add unicorn/require-post-message-target-origin rule
(#9684) (yefan)
- 474a57b linter: A new multi-file analysis runtime (#9383) (branchseer)

### Bug Fixes

- 6c0978b linter: No-single-promise-in-promise-methods: do not fix
Promise.all when chained (#9697) (camchenry)
- ab594f1 linter: Turn oxc/no-redundant-constructor-init into
typescript/no-unnecessary-parameter-property-assignment (#9618) (Uli)
- 91c009a linter: Add missing fail cases in
`eslint-no-array-constructor` (#9659) (therewillbecode)
- 2810e5b linter: Add missing fail cases in eslint/no-self-compare
(#9693) (therewillbecode)

### Refactor

- b9ab60b linter: Remove if let nesting from `bad-min-max-function`
(#9722) (therewillbecode)
- 90b0227 linter: Remove if let nesting from
`eslint-operator-assignment` (#9721) (therewillbecode)
- 5ef578e linter: Improve `jest/no-alias-methods` (#9694)
(therewillbecode)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
@therewillbecode therewillbecode deleted the refactor/eslint-operator-assignment branch March 13, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants